Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] concatenate multiple game launch options (f.e. gamemode, mangohud, gamescope, proton version, steam linux runtime) #465

Closed
frostworx opened this issue May 16, 2022 · 4 comments

Comments

@frostworx
Copy link
Collaborator

frostworx commented May 16, 2022

I currently rewrite and merge all functions which create the final game launch command based on the functions and tools enabled by the user.
I hope it will be working just fine on commit (soon), but several tool combinations might not work as expected (f.e. could require a different sort order or a "--" seperator between the separate commands), so it would be nice if some people tested the new function early and report back.

What helps with testing:

The steamtinkerlaunch log file (the log for the last game start as usual can be found under /dev/shm/steamtinkerlaunch/steamtinkerlaunch.log)
will explicitly log the initial incoming game launch command (launchSteamGame - Original incoming start command)
and the final concatenated command (launchSteamGame - Final outgoing start command)

It would be nice if you check the final command for missing or wrong parameters, I might have missed something.
What also would help is logging a working functional steam launch option which uses multiple external tools without using steamtinkerlaunch, f.e. by
using a steam launch option like
/usr/bin/gamemoderun /usr/bin/mangohud %command% > /tmp/game-testrun.log
(of course your tools might vary)

I'll drop a note here when the initial rewrite landed in git

The initial rewrite just landed

Happy testing/reporting (I might take a bit longer with replies than usual)

Thanks for your interest.

@zany130
Copy link
Collaborator

zany130 commented May 25, 2022

finally got around to testing this. Sorry for the delay.

steamtinkerlaunch as a compat tool


With just useslr it still doesn't find/use SLR, but with forceslr
games launch even with mangohud, gamemode, and now gamescope (Since I'm using AMD now 😄)

steamtinkerlaunch as a lunch command


setting useslr is enough as previously mentioned and finds and uses slr from the incoming proton commands

Even better it works with mangohud,gamemode, and gamescope enabled now 🥳 (again I previously reported games would not launch with those options enabled and SLR for those who didn't see the other SLR issue)

Next I will try to see if other situations where using gamemode or mangohud (and possibly gamescope) was not working with other tools (such as cheat engine) and report back on that.

@frostworx
Copy link
Collaborator Author

thx for testing. I'd say so far so good. have fun with your new gpu :)

@frostworx
Copy link
Collaborator Author

Assuming you're testing alone here, @zany130. Are you still planning to test here anything? Else I'd close here.
Take your time, I just don't like "idling" issues :)

@zany130
Copy link
Collaborator

zany130 commented Jun 7, 2022

sorry been busy with other stuff so I put this on the back burner (actually started getting back to it yesterday and found a few unrelated bugs which I'll open issues for (even one that was super simple so I'm taking advantage and learning how to do a PR)

from my testing cheat engine now works when using game mode (before it wasn't) so this seems to fix it 🥳 There an issue when enabling both gamescope and cheatengine and that's that cheat engine will be launched in the same gamescope window as the game (which is not good) but I'll open a separate issue for that

@zany130 zany130 closed this as completed Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants