Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special character in registry_version causes process exist: #405

Open
mgirard1mtx opened this issue Aug 28, 2024 · 2 comments
Open

Special character in registry_version causes process exist: #405

mgirard1mtx opened this issue Aug 28, 2024 · 2 comments

Comments

@mgirard1mtx
Copy link

Setup a NMOS node (no MQTT) with an invalid registry version (ex: "An I" instead of "v1.3").

Application is force to stop.

StdErr:

terminate called after throwing an instance of 'web::uri_exception' what():  provided uri is invalid: http://127.0.0.1:1/x-nmos/registration/An I

It seems the code is missing validation or HTTP character escape (ex: %20 for space).

@mgirard1mtx
Copy link
Author

In our application we inserted additional validation of the registry_version based on the is specification.

@garethsb
Copy link
Contributor

If you mean the setting, it's intentional that this causes an exception and terminate, because this is a programming issue not a condition to be recovered from

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants