Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on missing commit author login #55

Closed
dgw opened this issue Jan 9, 2020 · 1 comment · Fixed by #59
Closed

Error on missing commit author login #55

dgw opened this issue Jan 9, 2020 · 1 comment · Fixed by #59
Assignees
Labels
Milestone

Comments

@dgw
Copy link
Member

dgw commented Jan 9, 2020

As an example, sopel-irc/sopel@30cddb2 yields the following error in the github plugin:

TypeError: 'NoneType' object is not subscriptable (file
"/usr/local/lib/python3.6/site-packages/sopel_modules/github/github.py",
line 209, in commit_info)

Assuming that instance is up to date, that line number points to

data['author']['login'],

It makes sense, since that commit appears not to be associated with a GitHub user. I'd need to inspect the API response to be sure, but I'm reasonably confident that the issue is there.

@dgw dgw added the bug label Jan 9, 2020
@dgw dgw added this to the 0.3.0 milestone Jan 9, 2020
@dgw dgw self-assigned this Jan 9, 2020
@dgw
Copy link
Member Author

dgw commented Feb 2, 2020

Yep, the author object is null for that commit, I guess because the email address doesn't match any known GitHub user. Fix incoming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant