Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Listen for standalone ticket references #8

Closed
dgw opened this issue Jun 25, 2018 · 1 comment · Fixed by #65
Closed

[Feature] Listen for standalone ticket references #8

dgw opened this issue Jun 25, 2018 · 1 comment · Fixed by #65
Milestone

Comments

@dgw
Copy link
Member

dgw commented Jun 25, 2018

A number of IRC bots that support GitHub also detect issue/PR references without requiring that the reference be a URL. For example, if someone says, Yeah, that happens because of a regression in #9001, the bot will dig up the details for #9001 and send them to the channel.

sopel-github doesn't currently do this, but it would probably be a useful function for Sopel's own IRC channel, since issue numbers get thrown around there a fair bit. An admin-/op-only command like .gh-hook would need to be added for configuring the target repo for any given channel.

Conveniently, GitHub's issues API endpoint returns data for PRs too, so there's no need to check which type an in-text reference to #9001 is before fetching its info. (The id returned for a PR differs depending on which endpoint is used, but we don't use that particular property anywhere.)

@dgw dgw changed the title [Feature] Listen for standalone ticket references on a per-channel basis [Feature] Listen for standalone ticket references Jun 25, 2018
@half-duplex
Copy link
Member

From IRC discussion with @dgw:
Ideal would be to default both the github user and repo to what's configured, so that all three of these would work with sopel-irc/sopel as the configured repo:

  • #123 -> sopel-irc/sopel#123
  • sopel.chat#555 -> sopel-irc/sopel.chat#555
  • SpiceBot/SpiceBot#432 (unchanged)

@dgw dgw added this to the 0.3.0 milestone Apr 10, 2019
@dgw dgw modified the milestones: 0.3.0, 0.4.0 Jan 30, 2020
@dgw dgw closed this as completed in #65 May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants