-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the disabling of repetition detection #1618
Comments
This is something I've been doing for the past few weeks with my dev bot. This would be a good addition to the new flood controls in #1518 ,,, I do agree heavily with #1559 that the current state of the bot does NOT uniformly rate limit, and that these flood tweaks should filter through I think #1518 and this should be added, but moreso in the form that @HumorBaby proposes in #1559 . |
This is a "nice to have" that we can work on for 7.1. It won't add anything backward-incompatible, and so we don't need to find time to build and ship it in 7.0. |
Just checking in on this - now that the custom flood protection patches have landed, I'd be happy to submit a PR for this (if welcome). Would "repetition_filter" be an acceptable name for such a setting? |
For a simple toggle, I'd name it something like |
@predakanga @deathbybandaid you can check the PR #2320 if you want. The code is pretty straightforward. |
It would be useful for bot owners to be able to disable the repetition detection feature ("...").
We use Sopel primarily for devops and moderation, with modules which will often return repetitive answers (i.e. checking IPs or e-mails against blocklists), and thus far have had to fork Sopel to remove the "..." responses.
Other rate limits throughout Sopel are configurable (for instance,
@rate
); it would make sense to bring this in line with them, be it through a config option or a per-callable option to disable the feature.Additionally, this would be very helpful for debugging modules.
The text was updated successfully, but these errors were encountered: