Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reddit: comment links also output submission info #2175

Closed
dgw opened this issue Aug 17, 2021 · 0 comments · Fixed by #2176
Closed

reddit: comment links also output submission info #2175

dgw opened this issue Aug 17, 2021 · 0 comments · Fixed by #2176
Labels
Bug Things to squish; generally used for issues
Milestone
7.1.4

Comments

@dgw
Copy link
Member

dgw commented Aug 17, 2021

One of the bug fixes in 7.1.3 removed an anchor (&) from the end of post URLs. While it's now possible for Sopel to pick up reddit post links with e.g. ?sort=confidence tacked on (the intended result), that also means Sopel will happily output the post info along with comments (unintended side effect).

The link matching for posts needs to exclude anything that looks like a comment ID, but still match on anything else.
@dgw dgw added the Bug Things to squish; generally used for issues label Aug 17, 2021
@dgw dgw added this to the 7.1.4 milestone Aug 17, 2021
@dgw dgw mentioned this issue Aug 18, 2021
Merged
4 tasks
@dgw dgw closed this as completed in #2176 Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Things to squish; generally used for issues
Projects
None yet
Milestone
7.1.4
Development

Successfully merging a pull request may close this issue.

reddit: handle post and comment links in one regex sopel-irc/sopel
1 participant
@dgw