Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wikipedia: Use db rather than config to determine default language per channel #827

Closed
embolalia opened this issue Jun 28, 2015 · 2 comments · Fixed by #2142
Closed

wikipedia: Use db rather than config to determine default language per channel #827

embolalia opened this issue Jun 28, 2015 · 2 comments · Fixed by #2142
Assignees
@dgw
Labels
Easyfix Bugs or Tweaks that are easy for a new contributor to fix or implement Low Priority Tweak
Milestone
8.0.0

Comments

@embolalia
Copy link
Contributor

No description provided.

@embolalia embolalia mentioned this issue Jun 28, 2015
Closed
@dgw dgw added Easyfix Bugs or Tweaks that are easy for a new contributor to fix or implement Low Priority Tweak labels Nov 21, 2019
@dgw dgw changed the title Wikipedia: Use db rather than config to determine default language per channel wikipedia: Use db rather than config to determine default language per channel Nov 21, 2019
@dgw dgw self-assigned this Apr 12, 2020
@dgw dgw added this to the 7.1.0 milestone Apr 12, 2020
@dgw
Copy link
Member

dgw commented Apr 12, 2020

This is easy to do, and we should do it sooner rather than later so we can deprecate the config language value per channel during 7.x and remove it in 8.0 without the deprecation and removal being too close together. Next time I'm in the mood to work on something fairly simple, hopefully I'll remember this.

@dgw dgw mentioned this issue Aug 3, 2020
Merged
4 tasks
@Exirel Exirel modified the milestones: 7.1.0, 8.0.0 Sep 12, 2020
@Exirel
Copy link
Contributor

Exirel commented Sep 12, 2020

With #1916 merged all that is left is to wait for Sopel 8 to remove this setting.

@dgw dgw linked a pull request Jul 3, 2021 that will close this issue
wikipedia: remove deprecated lang_per_channel config setting #2142
Merged
4 tasks
@dgw dgw closed this as completed in #2142 Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgw dgw

Labels
Easyfix Bugs or Tweaks that are easy for a new contributor to fix or implement Low Priority Tweak
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

wikipedia: remove deprecated lang_per_channel config setting sopel-irc/sopel
3 participants
@dgw @embolalia @Exirel