Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docker backend #77

Closed
wants to merge 3 commits into from
Closed

Add docker backend #77

wants to merge 3 commits into from

Conversation

guyou
Copy link

@guyou guyou commented Aug 30, 2023 •
edited
Loading

Allow to access a running Docker container like docker exec does.

Fixes #76

@guyou
Copy link
Author

guyou commented Aug 30, 2023

Code is functional now.

I will update the documentation.

@sorenisanerd any opinion on this feature would be really appreciated.

@sorenisanerd
Copy link
Owner

I'm disinclined to merge this. gotty -w docker run ... works for every use case I can think of, so I don't think the added complexity is warranted. If you think I'm missing something, please re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tesak2001 Tesak2001 Tesak2001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add access to Docker
3 participants
@guyou @sorenisanerd @Tesak2001