Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HowTo cyanogenmod12.1 remount,rw and push #3

Open
lambdaupb opened this issue Jan 21, 2016 · 3 comments
Open

HowTo cyanogenmod12.1 remount,rw and push #3

lambdaupb opened this issue Jan 21, 2016 · 3 comments

Comments

@lambdaupb
Copy link

I had to mount -oremount,rw /system before replacing the framework.jar.
Furthermore adb push exited with a "permission denied" so i pushed it do my sdcard and moved the jar manually per terminal+su. Maybe this depends on "allow root for apps & debug" but i did not care to check.

so to replicate:

su
# <allow root>
mount -oremount,rw /system

# after framework.jar is somewhere on the internal storage/sdcard
mv /storage/sdcard0/framework.jar /system/framework/framework.jar
chown root:root /system/framework/framework.jar
chmod 644 /system/framework/framework.jar

Maybe this is helpful for others with Cyanogenmod 12.1

@souramoo
Copy link
Owner

The script does try to remount if it can. If you have had to do adb shell and then su it suggests that you are not running adbd in root mode on the device, which is why the pushing back to the phone is failing. If you run adb root (and accept on the phone) before running the script it should no longer give a permission denied error?

@lambdaupb
Copy link
Author

Quite possible.

Maybe add a section to the README stating that requirement. I was to lazy to check since I knew how to do it manually, but more novice users might get stuck.

Furthermore, you could replace the subprocess.call statements in the root+remount part with subprocess.check_call and print an appropriate message.

@ale5000-git
Copy link
Contributor

ale5000-git commented Sep 1, 2016

adb just display a textual error but it doesn't really fail so subprocess.check_call do nothing in this case, although it is still good to use it for other possible more serious errors.

Pull request #20 replace subprocess.call with subprocess.check_call to prevent other errors but it stil doesn't fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants