Rename route

Author: angelsl

lib/cadet_web/router.ex

@@ -132,6 +132,7 @@ defmodule CadetWeb.Router do
     put("/users", AdminUserController, :upsert_users_and_groups)
     put("/users/:course_reg_id/role", AdminUserController, :update_role)
     delete("/users/:course_reg_id", AdminUserController, :delete_user)
+    get("/users/:course_reg_id/goals", AdminGoalsController, :index_goals_with_progress)
     post("/users/:course_reg_id/goals/:uuid/progress", AdminGoalsController, :update_progress)
 
     put("/achievements", AdminAchievementsController, :bulk_update)
@@ -140,7 +141,6 @@ defmodule CadetWeb.Router do
 
     get("/goals", AdminGoalsController, :index)
     put("/goals", AdminGoalsController, :bulk_update)
-    get("/goals/:course_reg_id", AdminGoalsController, :index_goals_with_progress)
     put("/goals/:uuid", AdminGoalsController, :update)
     delete("/goals/:uuid", AdminGoalsController, :delete)
 

test/cadet_web/admin_controllers/admin_goals_controller_test.exs

@@ -54,7 +54,7 @@ defmodule CadetWeb.AdminGoalsControllerTest do
     end
   end
 
-  describe "GET v2/courses/:course_id/admin/goals/:userid" do
+  describe "GET v2/courses/:course_id/admin/users/:course_reg_id/goals" do
     @tag authenticate: :staff
     test "succeeds for staff", %{conn: conn} do
       course = conn.assigns.test_cr.course
@@ -77,7 +77,7 @@ defmodule CadetWeb.AdminGoalsControllerTest do
 
       [resp_goal] =
         conn
-        |> get(build_path(course.id, course_reg.id))
+        |> get(build_user_goals_path(course.id, course_reg.id))
         |> json_response(200)
 
       assert goal_json_literal(5) = resp_goal
@@ -315,4 +315,8 @@ defmodule CadetWeb.AdminGoalsControllerTest do
   defp build_path(course_id, uuid, course_reg_id) do
     "/v2/courses/#{course_id}/admin/users/#{course_reg_id}/goals/#{uuid}/progress/"
   end
+
+  defp build_user_goals_path(course_id, course_reg_id) do
+    "/v2/courses/#{course_id}/admin/users/#{course_reg_id}/goals"
+  end
 end