Rename 'genericButton' -> 'controlButton'

Also avoided variable name negation by renaming its argument 'notMinimal' ->
'minimal'. Refactor ReplControl to list declarations in decreasing levels of
abstraction.

(addresses review in PR #35)

Author: ning-y

src/components/workspace/ReplControl.tsx

@@ -1,6 +1,5 @@
-import * as React from 'react'
-
 import { Button, IconName, Intent } from '@blueprintjs/core'
+import * as React from 'react'
 
 import { sourceChapters } from '../../reducers/states'
 
@@ -14,48 +13,47 @@ export interface IReplControlProps {
   handleChapterSelect: (e: React.ChangeEvent<HTMLSelectElement>) => void
 }
 
-const chapterSelect = (handleSelect = (e: React.ChangeEvent<HTMLSelectElement>) => {}) => (
-  <div className="pt-select pt-select">
-    <select defaultValue={sourceChapters.slice(-1)[0].toString()} onChange={handleSelect}>
-      {sourceChapters.map(chap => (
-        <option key={chap} value={chap}>
-          {`Source \xa7${chap}`}
-        </option>
-      ))}
-    </select>
-  </div>
-)
-
 class ReplControl extends React.Component<IReplControlProps, {}> {
   public render() {
-    const genericButton = (
-      label: string,
-      icon: IconName,
-      handleClick = () => {},
-      intent = Intent.NONE,
-      notMinimal = false
-    ) => (
-      <Button
-        onClick={handleClick}
-        className={(notMinimal ? '' : 'pt-minimal') + ' col-xs-12'}
-        intent={intent}
-        icon={icon}
-      >
-        {label}
-      </Button>
-    )
-    const evalButton = genericButton('', 'code', this.props.handleReplEval)
-    const clearButton = genericButton('', 'remove', this.props.handleReplOutputClear)
     return (
       <div className="row end-xs">
         <div className="pt-control-group pt-fill">
           {chapterSelect(this.props.handleChapterSelect)}
-          {evalButton}
-          {clearButton}
+          {controlButton('', 'code', this.props.handleReplEval)}
+          {controlButton('', 'remove', this.props.handleReplOutputClear)}
         </div>
       </div>
     )
   }
 }
 
+const controlButton = (
+  label: string,
+  icon: IconName,
+  handleClick = () => {},
+  intent = Intent.NONE,
+  minimal = true
+) => (
+  <Button
+    onClick={handleClick}
+    className={(minimal ? 'pt-minimal' : '') + ' col-xs-12'}
+    intent={intent}
+    icon={icon}
+  >
+    {label}
+  </Button>
+)
+
+const chapterSelect = (handleSelect = (e: React.ChangeEvent<HTMLSelectElement>) => {}) => (
+  <div className="pt-select pt-select">
+    <select defaultValue={sourceChapters.slice(-1)[0].toString()} onChange={handleSelect}>
+      {sourceChapters.map(chap => (
+        <option key={chap} value={chap}>
+          {`Source \xa7${chap}`}
+        </option>
+      ))}
+    </select>
+  </div>
+)
+
 export default ReplControl