Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from moment to dayjs #3041

Closed
RichDom2185 opened this issue Aug 31, 2024 · 5 comments · Fixed by #3053
Closed

Migrate from moment to dayjs #3041

RichDom2185 opened this issue Aug 31, 2024 · 5 comments · Fixed by #3053
Labels
Enhancement New feature request good first issue Good for newcomers

Comments

@RichDom2185
Copy link
Member

Should be a more modern, much more lightweight, mostly drop-in replacement

@RichDom2185 RichDom2185 added Enhancement New feature request good first issue Good for newcomers labels Aug 31, 2024
@sham-k
Copy link

sham-k commented Sep 3, 2024

hey i would like to implement this.

@RichDom2185
Copy link
Member Author

Hi, sure, thanks!

@sham-k
Copy link

sham-k commented Sep 5, 2024

Hi, sure, thanks!

hey i'm currently trying to push my changes but theres a bunch of test failures is this the normal workflow where i have to fix all the failures or my push will get rejected ?

@sham-k
Copy link

sham-k commented Sep 21, 2024

???

@sayomaki
Copy link
Contributor

Hi @sham-k, thank you for working on this, and apologies for the late reply. Currently, there is a pre-push hook (that runs before you push) to automatically perform linting and testing of the code.

You may skip this if you are just pushing to your own fork, using git push --no-verify, but for your PR we would expect that the code passes testing and is error-free, as well as conforming to our code linting requirements.

As for the tests, the frontend comes with an extensive test suite to ensure code reliability. Regression tests are run automatically when you want to push changes to this repository. The regression tests are generated using jest and stored as snapshots in src/__tests__. If you are happy with the changes that you have made (and confirmed that there are no regression), you may update the regression tests by running: yarn test --updateSnapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants