Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider change in location of the ~/GlyphsFilters directory for filter list definition files #9

Open
chrissimpkins opened this issue Jul 30, 2018 · 4 comments

Comments

@chrissimpkins
Copy link
Member

chrissimpkins commented Jul 30, 2018

Comments from Georg Seifert on the Glyphs app forum:

And I would strongly advise agains putting something in ~/GlyphsFilters. Those things belong in the App Support folder.

I really meant it when I when I said to not store stuff in the users main folders. That is like office marking a folder with internal shit in my documents folder. That is so annoying.

Shall we move the entire GlyphsFilters directory to a Glyphs application specific path on the path Application Support/Glyphs as Georg recommended?

Pros:

  1. eliminates an application-specific directory under a user's $HOME directory

Cons:

  1. makes the directory less accessible to the average user for modification of the contents, review of logs, access to their backup files.
  2. anyone who begins to use the plugin with the current approach has to modify their setup following the change, or we have to create a transition approach...

Con (1) is addressed by the existing plugin menu item under the Glyphs Edit menu that automates opening of this directory in the macOS Finder window. This could be easily changed to the path that he suggested. That doesn't make it simple for many users to open through text editor menus/dialogs in order to edit their files, though most support drag/drop of the file on the editor icon. By design, users must directly modify the text file contents of this directory in order to use the plugin.

We could consider saving the backup files and logs under Application Support/Glyphs if this is felt to be a better approach for infrequently accessed but occasionally necessary data related to the plugin?

@schriftgestalt
Copy link
Contributor

That doesn't make it simple for many users to open through text editor menus/dialogs in order to edit their files

I think, users that are able to save a text file with the needed content can find the file in the Applications support folder. Or you could change the menu command that it will open the file in the default text editor automatically and create if it didn't exist yet.

@chrissimpkins
Copy link
Member Author

Thanks Georg. Appreciate the feedback. Let me look into it.

@chrissimpkins
Copy link
Member Author

There will be multiple files in the directory for most users (1:1 map of filter to definition file for local definitions). We can definitely open the entire directory for users though.

@schriftgestalt
Copy link
Contributor

I just had a look at the stat of the plugin and I need to remove it from the Glyphs 3 Plugin Manager as there are too many issue (e.g. hard coded paths). And this issue is not resolved, yet.

And you argument about people being able to find stuff. I just got a notification from the plugin to check the log. Without looking at the source code of the plugin I was not able to find that log. You could have written it to the macro window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants