feat(chore): add tenant provision in audit logs #102
Conversation
package.json
Outdated
| @@ -61,6 +61,7 @@ | |||
| "@loopback/core": "^5.1.5", | |||
| "@loopback/repository": "^6.1.5", | |||
| "@loopback/sequelize": "^0.5.4", | |||
| "@sourceloop/core": "^11.0.2", | |||
There was a problem hiding this comment.
wont this create a cyclic dependency
| @@ -59,6 +59,7 @@ export function AuditRepositoryMixin< | |||
| entityId: entity.getId(), | |||
| actedOn: this.entityClass.modelName, | |||
| actionKey: opts.actionKey, | |||
| tenantId: user.tenantId, | |||
There was a problem hiding this comment.
what if the user.tenantId is undefined
then defaultTenantId should be saved
There was a problem hiding this comment.
user.tenantId can never be undefined. as it is mentioned as required in our authentication service. it user didn't provide its values then he/she will not able to login.
there is also one defaultTenantId, but if tenantid can not be NULL then why do we need to mention defaultid here
src/repositories/audit.repository.ts
Outdated
|
|
||
| @tenantGuard() |
There was a problem hiding this comment.
create, update and delete is already handled via mixin and we dont have any read operation in this
do we really need this
There was a problem hiding this comment.
AuditLogRepository and AuditLog Model of loopback4-audit-log and @sourceloop/audit-service should be same, otherwise they causes error.
will test after removing tenatguard from here, if everything works fine, then will remove it.
Provision to get tenant wise logs BREAKING CHANGE: Provision to get tenant wise logs 101
|
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
add tenant provision in audit logs
BREAKING CHANGE:
add tenant provision in audit logs
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #101
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: