Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Start tagging releases #309

Open
maximbaz opened this issue Aug 17, 2018 · 1 comment
Open

Start tagging releases #309

maximbaz opened this issue Aug 17, 2018 · 1 comment

Comments

@maximbaz
Copy link

Hello, I'd like to create a go-langserver package for Arch Linux, but such package needs to follow official releases.

I've noticed that go-langserver -version is a thing and there even are instructions in the source code:

go-langserver/main.go

Lines 39 to 44 in 7df19dc

// version is the version field we report back. If you are releasing a new version:
// 1. Create commit without -dev suffix.
// 2. Create commit with version incremented and -dev suffix
// 3. Push to master
// 4. Tag the commit created in (1) with the value of the version string
const version = "v2-dev"

I would highly recommend following semantic versioning:

  • Define version as MAJOR.MINOR.PATCH
  • Bump MAJOR if you merge a commit that breaks backwards compatibility.
  • Bump MINOR if you add functionality in backwards-compatible manner.
  • Bump PATCH if you are making a backwards-compatible bug fix.

For packaging purposes all I need is a tagged commit, Github and I will do the rest, -version flag is a nice bonus if you can keep it up to date.

I'm making this package so that it's simpler for people to install your tool and update it as time goes by. I would also like to ask you to keep making releases often, so that users actually benefit from following official releases.

I'd like to highlight that by making official releases you are not binding yourselves to support old versions, it is perfectly valid to ask users to upgrade. On the contrary, you will start seeing a version in bug reports, and hopefully it will help you triage some issues faster.

Let me know if you have some questions or concerns.

@maximbaz
Copy link
Author

To follow-up on this, first of all thanks @keegancsmith for tagging v2.0.0 soon after I opened this ticket, as you can see by the number of upvotes this is truly important for other people.

After seeing the release tagged I feel encouraged now to create a package for Arch Linux and I will do so, I would only like to confirm with you guys that you are planning to tag new releases on frequent basis. I'm asking because in my mind having an "official" package that is based on very old source code is worse than having no package at all, I don't want to give people a false sense of trust that this package is recommended for use unless the developers commit to keep tagging new releases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant