Skip to content
This repository has been archived by the owner on Jul 2, 2024. It is now read-only.

Breadcrumbs lead to 404s if an ancestor dir has no index.md page #2066

Open
sqs opened this issue Feb 1, 2022 · 4 comments · Fixed by #2105
Open

Breadcrumbs lead to 404s if an ancestor dir has no index.md page #2066

sqs opened this issue Feb 1, 2022 · 4 comments · Fixed by #2105

Comments

@sqs
Copy link
Member

sqs commented Feb 1, 2022

Someone reported this issue to me about the page at https://handbook.sourcegraph.com/strategy-goals/strategy:

Btw, funny thing but the handbook sometimes drops an extra “/strategy/“ in the link urls for that section, thus sometimes returning 404s while navigating back and forth.

I repro'd it on these links (red arrow in screenshot). (I am confirming with the person that this is what they saw, too.)

image

In this case, it leads to https://handbook.sourcegraph.com/strategy-goals/strategy/use_cases, which 404s because there is no index.md document in that directory.

@marybelzer
Copy link
Contributor

Thanks for raising this - I will sort out the issue with the use cases pages. The issue of adding an extra /strategy/ is something we've seen reported a few times recently, and Katy is actively working on a fix that we're tracking here.

@marybelzer marybelzer moved this to Backlog in Content Platform Work Feb 1, 2022
@marybelzer marybelzer moved this from Backlog to Ready for Development in Content Platform Work Feb 1, 2022
@sqs
Copy link
Member Author

sqs commented Feb 1, 2022

@marybelzer Awesome, thank you!

@marybelzer marybelzer moved this from Ready for Development to In Progress in Content Platform Work Feb 1, 2022
@marybelzer marybelzer linked a pull request Feb 1, 2022 that will close this issue
Repository owner moved this from In Progress to Done in Content Platform Work Feb 1, 2022
@rafaelrebolleda
Copy link

Similar issue:

  1. Start from "Working with use cases" (tried direct url and from handbook search)
  2. Click on the link "use cases" right on the first paragraph
  3. Click on any use case on the list, they all have the extra "/strategy/" on the url.
  4. 404

More over, if you copy+paste the "use cases" link from step 2 on an incognito window straight away, you get the same 404 following on the links for each use case.

404s.mov

@sqs
Copy link
Member Author

sqs commented Feb 2, 2022

@rafaelrebolleda Thank you!

@katjuell katjuell self-assigned this Feb 9, 2022
@katjuell katjuell reopened this Feb 9, 2022
Repository owner moved this from Done to Ready for Development in Content Platform Work Feb 9, 2022
@elzannewentzel elzannewentzel moved this from Ready for Development 🚦 to Backlog 📓 in Content Platform Work Jun 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Backlog 📓
Development

Successfully merging a pull request may close this issue.

4 participants