Dark text on dark background for broken links in storybook

[jasongornall]

• Sourcegraph version:

https://storybook.sgdev.org/?path=/story/wildcard-feedbackprompt--feedback-prompt-exampless

• Platform information:
  Web / Chrome / Desktop / PC

Steps to reproduce:

1. Click the link in dark mode and observe the black text on the dark background

Expected behavior:

The copy should be white

Actual behavior:

The copy is dark

If would like immediate help on this, please email support@sourcegraph.com (you can still create the issue, but there are not SLAs on issues like there are for support requests).

[jasongornall]

I dug into this issue as my first attempt at changing the codebase.

It looks like this view is entirely generated inside of storybook

All the other views work properly because of how the theme are imported directly from BrandedStory But because this isn't a react component it isn't importing it on the fly when the context changes.

This must be a problem for other apps right? A brief exploration of other storybooks yielded yes and the new version has a hardcoded background

voila! I say Let's just upgrade storybook and the problem is solved.

After upgrade I see the new storybook broken link looks great!

A quick VQA later results in some nasty react router crashes.

I then learn that the new version of storybook is NOT compatible with react router 5!!

Investigating upgrading react router they actively advise you to wait and not upgrade. until they can make it backwards compatible.

TLDR. new storybook fixes this and it needs react router 6 to work and react router 6 can't be upgraded yet (or shouldn't?).

[umpox]

@jasongornall

I got an email from the React Router team a couple of weeks ago saying that the migration was ready, with a plan on how to do it. I've emailed back to clarify what the actual status is, as the package has definitely been released but we should avoid doing so if it's not actually stable yet.

I did a quick PR here to enable https://github.com/sourcegraph/sourcegraph/pull/33835, and created an issue to migrate: https://github.com/sourcegraph/sourcegraph/issues/33834

[valerybugakov]

Fixed in https://github.com/sourcegraph/sourcegraph/pull/36437