refactor: Extract planner errors to dedicated file #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/errors
shahzadlone
approved these changes
Jan 16, 2023
There was a problem hiding this comment.
Overall LGTM.
Just a question (non-blocking), what do you mean by:
"...the cleanliness of the eventual error is unimportant..." in: 92acd60 (#1034)
It should never reach users, and any error that does will be meaningless to them - at somepoint stuff like that can be wrapped with something generic like "Whoops something went wrong, hopefully all your data is still there, please send the below stacktrace to support" |
AndrewSisley
force-pushed
the
sisley/refactor/I257-mv-planner-errs
branch
from
72cb863 to
50974cc
Compare
I checked, we have tests that check this and they never reach this line
Code path cannot be reached, cannot be tested, and can only be introduced via internal programming error (in which case a later error will be about as useful)
Variable can not be nil, it is internal only and will always have a value unless an earlier error is silently skipped (in which case the cleanliness of the eventual error is unimportant)
Variable can not be nil, it is internal only and will always have a value unless an earlier error is silently skipped (in which case the cleanliness of the eventual error is unimportant)
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Remove impossible error (on create) I checked, we have tests that check this and they never reach this line * Remove impossible error (internal, colName) Code path cannot be reached, cannot be tested, and can only be introduced via internal programming error (in which case a later error will be about as useful) * Remove impossible error (explain.plan) Variable can not be nil, it is internal only and will always have a value unless an earlier error is silently skipped (in which case the cleanliness of the eventual error is unimportant) * Remove impossible error (request.plan) Variable can not be nil, it is internal only and will always have a value unless an earlier error is silently skipped (in which case the cleanliness of the eventual error is unimportant) * Extract planner errors to dedicated file
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Remove impossible error (on create) I checked, we have tests that check this and they never reach this line * Remove impossible error (internal, colName) Code path cannot be reached, cannot be tested, and can only be introduced via internal programming error (in which case a later error will be about as useful) * Remove impossible error (explain.plan) Variable can not be nil, it is internal only and will always have a value unless an earlier error is silently skipped (in which case the cleanliness of the eventual error is unimportant) * Remove impossible error (request.plan) Variable can not be nil, it is internal only and will always have a value unless an earlier error is silently skipped (in which case the cleanliness of the eventual error is unimportant) * Extract planner errors to dedicated file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Part of #257
Description
Extracts planner errors to dedicated files (includes mapper). Continuation of work done at the end of last year whilst waiting on other discussions to progress.