Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove generic param from client.NewErrUnexpectedType #1040

Closed
AndrewSisley opened this issue Jan 17, 2023 · 1 comment
Closed

Remove generic param from client.NewErrUnexpectedType #1040

AndrewSisley opened this issue Jan 17, 2023 · 1 comment
Assignees
@AndrewSisley
Labels
area/errors Related to the internal management or design of our error handling system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Milestone
DefraDB v0.5

Comments

@AndrewSisley
Copy link
Contributor

Requested and outvoted on #1037 (comment)
@AndrewSisley AndrewSisley added area/errors Related to the internal management or design of our error handling system refactor This issue specific to or requires *notable* refactoring of existing codebases and components labels Jan 17, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.5 milestone Jan 17, 2023
@AndrewSisley AndrewSisley self-assigned this Jan 18, 2023
@AndrewSisley AndrewSisley mentioned this issue Jan 18, 2023
Closed
@AndrewSisley
Copy link
Contributor Author

Done and rejected in #1041 - people seem to prefer the generic (partly/mostly due to the eye-sore when dealing with primitives without a generic)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/errors Related to the internal management or design of our error handling system refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
DefraDB v0.5
Development

Successfully merging a pull request may close this issue.

refactor: Remove generic param for error sourcenetwork/defradb
1 participant
@AndrewSisley