test: Fetch documents on test execution start #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
AndrewSisley
changed the title
The document set needs to include documents created in the startup actions - in the case of the change detector, this may be done in another process and so they must be fetched in the correct order from the database.
Codecov Report
@@ Coverage Diff @@
## develop #1163 +/- ##
===========================================
- Coverage 68.30% 68.28% -0.02%
===========================================
Files 181 181
Lines 17007 17007
===========================================
- Hits 11616 11613 -3
- Misses 4424 4426 +2
- Partials 967 968 +1
|
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
The document set needs to include documents created in the startup actions - in the case of the change detector, this may be done in another process and so they must be fetched in the correct order from the database.
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
The document set needs to include documents created in the startup actions - in the case of the change detector, this may be done in another process and so they must be fetched in the correct order from the database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1162
Description
The schema updates PR exposed a bug in the new integration test framework where documents created in the setup phase (using the target branch code) were not available using the execution phase (using the current/test branch), resulting in index out of bounds exceptions when trying to reference them.
Bug was previously not visible as the Schema Updates tests were the first to split Create and Update document actions on either side of the change detector.
This PR fetches documents created in the setup phase at the start of the execution phase, allowing them to be referenced correctly.