fix: Fix P2P collection CLI commands #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
AndrewSisley
force-pushed
the
sisley/fix/I1294-cli-p2p
branch
from
08e5041 to
5511867
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1295 +/- ##
===========================================
+ Coverage 70.41% 70.44% +0.02%
===========================================
Files 184 184
Lines 17825 17825
===========================================
+ Hits 12552 12556 +4
+ Misses 4318 4315 -3
+ Partials 955 954 -1
|
fredcarle
approved these changes
Apr 5, 2023
I wonder if the path was moved since and these lines were missed. |
AndrewSisley
force-pushed
the
sisley/fix/I1294-cli-p2p
branch
from
5511867 to
14141a9
Compare
That could make sense as it was under a different command previously. |
To match what is present in the readme
To match what is present in the readme
To match what is present in the readme
AndrewSisley
force-pushed
the
sisley/fix/I1294-cli-p2p
branch
from
14141a9 to
d33c207
Compare
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Configure add to be child of rpc To match what is present in the readme * Configure get to be child of rpc To match what is present in the readme * Configure remove to be child of rpc To match what is present in the readme
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Configure add to be child of rpc To match what is present in the readme * Configure get to be child of rpc To match what is present in the readme * Configure remove to be child of rpc To match what is present in the readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1294
Description
Fixes the P2P collection CLI commands which were previously bound as children of the replicator command. The readme and code suggests they should be children of the rpc command.