fix: Improve error message for NonNull GQL types #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
feature
AndrewSisley
force-pushed
the
sisley/fix/I1192-not-null-err
branch
2 times, most recently
from
505c78f to
bf2b2df
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1333 +/- ##
===========================================
+ Coverage 70.51% 70.55% +0.03%
===========================================
Files 184 184
Lines 17801 17803 +2
===========================================
+ Hits 12553 12561 +8
+ Misses 4289 4285 -4
+ Partials 959 957 -2
|
AndrewSisley
force-pushed
the
sisley/fix/I1192-not-null-err
branch
from
bf2b2df to
f2377d8
Compare
shahzadlone
reviewed
Apr 11, 2023
Comment on lines
+39
to
+41
| // NonNull is the literal name of the GQL type, so we have to disable the linter | ||
| //nolint:revive | ||
| ErrNonNullNotSupported = errors.New("NonNull fields are not currently supported") |
There was a problem hiding this comment.
suggestion: Instead of suppressing with linter, can do this:
Suggested change
| // NonNull is the literal name of the GQL type, so we have to disable the linter | |
| //nolint:revive | |
| ErrNonNullNotSupported = errors.New("NonNull fields are not currently supported") | |
| // NonNull is the literal name of the GQL type, so we have to disable the linter | |
| //nolint:revive | |
| ErrNonNullNotSupported = errors.New("currently NonNull fields are not supported") |
There was a problem hiding this comment.
I'm pretty against changing user-visible behaviour for the sake of linters, regardless of how minimal the change might be.
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Add test adding schema with NonNull field * Improve error message for NonNull GQL types
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Add test adding schema with NonNull field * Improve error message for NonNull GQL types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1192
Description
Improves the error message when attempting to declare a GQL schema with a NonNull field type.