Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace WaitForFoo chans with ring buffer #1357

Closed
AndrewSisley opened this issue Apr 17, 2023 · 0 comments · Fixed by #1359
Closed

Replace WaitForFoo chans with ring buffer #1357

AndrewSisley opened this issue Apr 17, 2023 · 0 comments · Fixed by #1359
Assignees
@AndrewSisley
Labels
area/p2p Related to the p2p networking system bug Something isn't working
Milestone
DefraDB v0.5.1

Comments

@AndrewSisley
Copy link
Contributor

AndrewSisley commented Apr 17, 2023 •
edited
Loading

See #1338 (comment) and dev-db chan "P2P EventBus issue" for more info.

Replace these channels with basic ring buffer implementation. Can then later be refactored out to the events package.
@AndrewSisley AndrewSisley added bug Something isn't working area/p2p Related to the p2p networking system labels Apr 17, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.5.1 milestone Apr 17, 2023
@AndrewSisley AndrewSisley self-assigned this Apr 17, 2023
@AndrewSisley AndrewSisley changed the title Replace WaitForFoo chans with events.simpleChannel Replace WaitForFoo chans with ring buffer Apr 17, 2023
@AndrewSisley AndrewSisley mentioned this issue Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndrewSisley AndrewSisley

Labels
area/p2p Related to the p2p networking system bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.5.1
Development

Successfully merging a pull request may close this issue.

fix: Use ring-buffer for WaitForFoo chans sourcenetwork/defradb
1 participant
@AndrewSisley