Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move to ipfs boxo #1393

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #1288

Description

This PR moves dependencies that are now under ipfs boxo to that dependency

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make test

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added action/no-benchmark Skips the action that runs the benchmark. dependencies Related to dependencies labels Apr 23, 2023
@fredcarle fredcarle added this to the DefraDB v0.5.1 milestone Apr 23, 2023
@fredcarle fredcarle requested a review from a team April 23, 2023 01:29
@fredcarle fredcarle self-assigned this Apr 23, 2023
@fredcarle fredcarle force-pushed the chore/I1288-ipfs-boxo branch from 74958b3 to 21f634b Compare April 23, 2023 02:01
@orpheuslummis
Copy link
Contributor

just noting that this PR bumps libp2p version to https://github.com/libp2p/go-libp2p/releases/tag/v0.27.0 v0.27 which basically adds a bunch of metrics

@orpheuslummis
Copy link
Contributor

orpheuslummis commented Apr 23, 2023

open question: I wonder how many of the remaining go-ipfs repos we use will then be ported to boxo and remain 'standalone'

Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cheers Fred

Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sorting these out.

@fredcarle fredcarle force-pushed the chore/I1288-ipfs-boxo branch from 21f634b to 4d2b241 Compare April 24, 2023 21:56
@fredcarle fredcarle force-pushed the chore/I1288-ipfs-boxo branch from 4d2b241 to d148603 Compare April 24, 2023 21:56
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #1393 (d148603) into develop (27f26b4) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1393      +/-   ##
===========================================
- Coverage    70.72%   70.70%   -0.03%     
===========================================
  Files          185      185              
  Lines        17884    17884              
===========================================
- Hits         12649    12645       -4     
- Misses        4283     4285       +2     
- Partials       952      954       +2     
Impacted Files Coverage Δ
api/http/handlerfuncs.go 77.44% <ø> (ø)
core/crdt/composite.go 61.53% <ø> (ø)
core/crdt/lwwreg.go 75.25% <ø> (ø)
datastore/blockstore.go 78.02% <ø> (ø)
datastore/dag.go 100.00% <ø> (ø)
db/db.go 71.42% <ø> (ø)
db/fetcher/versioned.go 59.13% <ø> (+1.61%) ⬆️
merkle/clock/clock.go 65.74% <ø> (ø)
merkle/clock/ipld.go 26.86% <ø> (ø)
net/peer.go 50.88% <ø> (ø)
... and 3 more

... and 3 files with indirect coverage changes

@fredcarle fredcarle merged commit 0e08406 into sourcenetwork:develop Apr 24, 2023
@fredcarle fredcarle deleted the chore/I1288-ipfs-boxo branch April 27, 2023 17:24
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Description
This PR moves dependencies that are now under ipfs boxo to that dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. dependencies Related to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate ipfs dependencies to ipfs' boxo
4 participants