test: Rework transaction test framework capabilities #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/testing
AndrewSisley
force-pushed
the
1602-txn-test-rework
branch
from
19b689b to
a1b7c0b
Compare
AndrewSisley
force-pushed
the
1602-txn-test-rework
branch
from
a1b7c0b to
1f9ecd7
Compare
AndrewSisley
commented
Jun 29, 2023
| action TransactionRequest2, | ||
| ) []datastore.Txn { | ||
| if action.TransactionID >= len(txns) { | ||
| txnsPointer *[]datastore.Txn, |
There was a problem hiding this comment.
note: The ptr param is quite ugly, but I think it is less ugly than returning txns from every test action handler. At somepoint we should probably just have a test-context object that hold txn, nodes, collections, etc, but not now.
Codecov ReportPatch coverage has no change and project coverage change:
@@ Coverage Diff @@
## develop #1603 +/- ##
===========================================
+ Coverage 73.59% 73.62% +0.03%
===========================================
Files 188 188
Lines 19608 19608
===========================================
+ Hits 14429 14435 +6
+ Misses 4112 4108 -4
+ Partials 1067 1065 -2
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Note: A couple of these were broken out of 'grouped' test. This is because I have no desire to convert all of the others within the same test function, it is a much lower priority to do so, and I have quite a strong dislike of such tests as it makes debugging them much harder than they would be if there was only one test in each test func.
AndrewSisley
force-pushed
the
1602-txn-test-rework
branch
from
1f9ecd7 to
d908b67
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
) ## Relevant issue(s) Resolves sourcenetwork#1602 ## Description Instead of a dedicated txn action (like we currently have), we can instead follow a similar pattern to node ids where any action can specify a transaction id. I would like to use this on other actions, most immediately for Lens testing, although it will likely be very useful elsewhere too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1602
Description
Instead of a dedicated txn action (like we currently have), we can instead follow a similar pattern to node ids where any action can specify a transaction id. I would like to use this on other actions, most immediately for Lens testing, although it will likely be very useful elsewhere too.