-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump to GoLang v1.20 #1689
Conversation
This action should fail as we use GoLang v1.19 which does have vulnerabilities, In the following commits the version will be bumped and then this action should show no vulnerabilities.
Terraform Format and Style
|
Terraform Format and Style
|
Codecov ReportPatch coverage has no change and project coverage change:
@@ Coverage Diff @@
## develop #1689 +/- ##
===========================================
+ Coverage 75.29% 75.40% +0.11%
===========================================
Files 208 208
Lines 21694 21694
===========================================
+ Hits 16333 16357 +24
+ Misses 4220 4199 -21
+ Partials 1141 1138 -3
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for doing that change. It will be good to avoid potential vulnerabilities in the future.
// create a consistent seed value for the random package | ||
// so we don't have random fluctuations between runs | ||
// (specifically thinking about the fixture generation stuff) | ||
seed := hashToInt64("https://xkcd.com/221/") | ||
rand.Seed(seed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsimnz Do you see value in having a consistent seed and passing it the place where the random generation happens (as now it's not a global thing but a local object we would have to pass around with an initiated seed).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made issue for tracking: #1690
## Relevant issue(s) - Resolves #2194 - Resolves #2196 ## Description - This is a routine version bump of GoLang, the previous bump was done in (#1689) - Also updates the golang version for AWS AMI generation. - Updated the `ONLY_DEFRADB_REPO_CI_PAT` token as the terraform build would fail otherwise as the token expired starting of this year.
## Relevant issue(s) - Resolves sourcenetwork#2194 - Resolves sourcenetwork#2196 ## Description - This is a routine version bump of GoLang, the previous bump was done in (sourcenetwork#1689) - Also updates the golang version for AWS AMI generation. - Updated the `ONLY_DEFRADB_REPO_CI_PAT` token as the terraform build would fail otherwise as the token expired starting of this year.
## Relevant issue(s) - Resolves sourcenetwork#2194 - Resolves sourcenetwork#2196 ## Description - This is a routine version bump of GoLang, the previous bump was done in (sourcenetwork#1689) - Also updates the golang version for AWS AMI generation. - Updated the `ONLY_DEFRADB_REPO_CI_PAT` token as the terraform build would fail otherwise as the token expired starting of this year.
## Relevant issue(s) - Resolves sourcenetwork#522 - Resolves sourcenetwork#1687 ## Description - This is a routine version bump of GoLang, the previous bump was done in (sourcenetwork#818) - This PR also introduces a new workflow action (not-mandatory to pass in order to merge) that was showing some vulnerabilities pre-version-bump, all of the vulnerabilities were resolved once the golang version was bumped. In future this trigger will be used to bump golang versions. - Also updates the golang version for AWS AMI generation. Note: - Before the bump we had 13 vulnerabilities: https://github.com/sourcenetwork/defradb/actions/runs/5629964770/job/15255493129?pr=1688 - After the bump: passing with no vulnerabilities. ## How has this been tested? - Added action that failed with vulnerabilities. - Bumped version. - Vulnerabilities were resolved and action passed. Specify the platform(s) on which this was tested: - Arch Linux
## Relevant issue(s) - Resolves sourcenetwork#2194 - Resolves sourcenetwork#2196 ## Description - This is a routine version bump of GoLang, the previous bump was done in (sourcenetwork#1689) - Also updates the golang version for AWS AMI generation. - Updated the `ONLY_DEFRADB_REPO_CI_PAT` token as the terraform build would fail otherwise as the token expired starting of this year.
Relevant issue(s)
Description
Note:
How has this been tested?
Specify the platform(s) on which this was tested: