refactor: Schema list output to include schemaVersionID #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsimnz
added
area/api
jsimnz
force-pushed
the
jsimnz/feat/schema-list-id-extension
branch
from
3e1dc28 to
994e657
Compare
jsimnz
changed the title
schemaVersionIDschemaVersionID
nasdf
approved these changes
Jul 24, 2023
@nasdf absolutely agree |
jsimnz
changed the title
schemaVersionIDschemaVersionID
jsimnz
changed the title
schemaVersionIDschemaVersionID.
jsimnz
changed the title
schemaVersionID.
Codecov ReportPatch coverage:
@@ Coverage Diff @@
## develop #1706 +/- ##
===========================================
+ Coverage 75.38% 75.42% +0.04%
===========================================
Files 208 208
Lines 21694 21698 +4
===========================================
+ Hits 16352 16364 +12
+ Misses 4203 4197 -6
+ Partials 1139 1137 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
reviewed
Jul 25, 2023
Comment on lines
+74
to
+75
| cmd.Printf("# Schema ID: %s\n", c.ID) | ||
| cmd.Printf("# Version ID: %s\n", c.VersionID) |
There was a problem hiding this comment.
thought: There is no test for these :,)
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…k#1706) ## Relevant issue(s) Resolves sourcenetwork#1705 ## Description Adds some additional `schemaID` and `schemaVersionID` fields to the `schema list` API, both HTTP and CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1705
Description
Adds some additional
schemaIDandschemaVersionIDfields to theschema listAPI, both HTTP and CLITasks
How has this been tested?
Specify the platform(s) on which this was tested: