feat: Make fetcher calculate docFetches and fieldFetches #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islamaliev
added
bug
islamaliev
changed the title
Codecov ReportPatch coverage:
@@ Coverage Diff @@
## develop #1713 +/- ##
===========================================
+ Coverage 75.32% 75.42% +0.10%
===========================================
Files 208 208
Lines 21727 21745 +18
===========================================
+ Hits 16364 16399 +35
+ Misses 4217 4206 -11
+ Partials 1146 1140 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
fredcarle
reviewed
Jul 26, 2023
islamaliev
force-pushed
the
fix/islam/doc-fetched
branch
from
afd5ddf to
bff4048
Compare
shahzadlone
previously requested changes
Jul 27, 2023
islamaliev
force-pushed
the
fix/islam/doc-fetched
branch
from
bff4048 to
730364f
Compare
islamaliev
changed the title
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…rk#1713) ## Relevant issue(s) Resolves sourcenetwork#1636 and sourcenetwork#1637 ## Description With this change the calculation of stats for fetching documents is moved to fetcher. This was necessary because each call to `fetcher.FetchNext...` could potentially perform multiple doc fetches. But scanNode (previously responsible for this) would just increment by 1. Moreover, scanNode would incorrectly count end of fetching (returned nil doc) as 1 as well. Also this fix introduces another (probably more important) metric `fieldFetches` which better indicates the execution cost because it much closer correlates with number of IO operations, as eace document's field is stored in a separate KV pair.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1636 and #1637
Description
With this change the calculation of stats for fetching documents is moved to fetcher.
This was necessary because each call to
fetcher.FetchNext...could potentially perform multiple doc fetches.But scanNode (previously responsible for this) would just increment by 1.
Moreover, scanNode would incorrectly count end of fetching (returned nil doc) as 1 as well.
Also this fix introduces another (probably more important) metric
fieldFetcheswhich better indicatesthe execution cost because it much closer correlates with number of IO operations, as eace document's
field is stored in a separate KV pair.
Tasks
How has this been tested?
Integration tests
Specify the platform(s) on which this was tested: