Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Discard index and subscription implicit transactions #1715

Merged
merged 2 commits into from
Jul 26, 2023
Merged

fix: Discard index and subscription implicit transactions #1715

merged 2 commits into from
Jul 26, 2023

Conversation

AndrewSisley
Copy link
Contributor

@AndrewSisley AndrewSisley commented Jul 26, 2023 •
edited
Loading

Relevant issue(s)

Resolves #1714

Description

Discard index and subscription implicit transactions.

I'm not sure if this was causing any problems, but they should be discarded.

@AndrewSisley AndrewSisley added bug Something isn't working area/datastore Related to the datastore / storage engine system labels Jul 26, 2023
@AndrewSisley AndrewSisley added this to the DefraDB v0.6 milestone Jul 26, 2023
@AndrewSisley AndrewSisley requested a review from a team July 26, 2023 16:43
@AndrewSisley AndrewSisley self-assigned this Jul 26, 2023
fredcarle
fredcarle approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch. I look forward to see if it will help with flakyness.

@AndrewSisley
Copy link
Contributor Author

LGTM! Good catch. I look forward to see if it will help with flakyness.

Sadly I don't think it will, I just spotted it whilst staring at the flaky problem :(

@fredcarle
Copy link
Collaborator

LGTM! Good catch. I look forward to see if it will help with flakyness.

Sadly I don't think it will, I just spotted it whilst staring at the flaky problem :(

Ahhh... You had my hopes up when I saw that you marked it as resolving #1702. :)

@AndrewSisley
Copy link
Contributor Author

LGTM! Good catch. I look forward to see if it will help with flakyness.

Sadly I don't think it will, I just spotted it whilst staring at the flaky problem :(

Ahhh... You had my hopes up when I saw that you marked it as resolving #1702. :)

I have linked it to the wrong ticket 😆 Sorry.

@codecov
Copy link

codecov bot commented Jul 26, 2023 •
edited
Loading

Codecov Report

Patch coverage: 74.29% and project coverage change: -0.03% ⚠️

Comparison is base (ca1cb68) 75.37% compared to head (35d5289) 75.35%.
Report is 1 commits behind head on develop.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1715      +/-   ##
===========================================
- Coverage    75.37%   75.35%   -0.03%     
===========================================
  Files          208      208              
  Lines        21717    21727      +10     
===========================================
+ Hits         16369    16371       +2     
- Misses        4207     4213       +6     
- Partials      1141     1143       +2
Flag Coverage Δ
all-tests 75.35% <74.29%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
planner/errors.go 0.00% <0.00%> (ø)
planner/planner.go 76.70% <ø> (ø)
planner/type_join.go 75.19% <56.25%> (ø)
db/collection_index.go 97.46% <100.00%> (+0.01%) ⬆️
db/subscriptions.go 83.72% <100.00%> (+8.05%) ⬆️

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2182f...35d5289. Read the comment docs.

@AndrewSisley AndrewSisley merged commit 2385525 into sourcenetwork:develop Jul 26, 2023
@AndrewSisley AndrewSisley deleted the 1702-txn-discard branch July 26, 2023 17:33
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@AndrewSisley
fix: Discard index and subscription implicit transactions (sourcenetw…
e402366 
…ork#1715)

## Relevant issue(s)

Resolves sourcenetwork#1714

## Description

Discard index and subscription implicit transactions.

I'm not sure if this was causing any problems, but they should be
discarded.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

Assignees

@AndrewSisley AndrewSisley

Labels
area/datastore Related to the datastore / storage engine system bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.6
Development

Successfully merging this pull request may close these issues.

Some implicit transactions are missing discards
2 participants
@AndrewSisley @fredcarle