ci: Run benchmarks only after linter check using jobs #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
source-devs
added
area/testing
…b depends on the lint job in one workflow
shahzadlone
force-pushed
the
lone/ci/benchmarks-to-run-after-linter
branch
from
e428956 to
779e9ad
Compare
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…b depends on the lint job in one workflow (sourcenetwork#209) DESCRIPTION: - Combine the Lint and Benchmark workflows so that the benchmark job depends on the lint job in one workflow. - The `GOPATH` and `HOME` directory on the custom GitHub runner was not being set be default. Which was giving me: `error: missing $GOPATH` which is a go bug. You can replicate the same bug on your machine by `HOME='' GOPATH='' go test ./..` - Set HOME for GO stuff to parent directory where our runner checks out our code. i.e. `/actions-runner/_work`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine the Lint and Benchmark workflows so that the benchmark job depends on the lint job in one workflow.
The
GOPATHandHOMEdirectory on the custom GitHub runner was not being set be default. Which was giving me:error: missing $GOPATHwhich is a go bug. You can replicate the same bug on your machine byHOME='' GOPATH='' go test ./..Set HOME for GO stuff to parent directory where our runner checks out our code. i.e.
/actions-runner/_work