Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing directive definitions in GQL schema #2312

Closed
jsimnz opened this issue Feb 14, 2024 · 0 comments · Fixed by #2369
Closed

Missing directive definitions in GQL schema #2312

jsimnz opened this issue Feb 14, 2024 · 0 comments · Fixed by #2369
Labels
area/query Related to the query component bug Something isn't working
Milestone

Comments

@jsimnz
Copy link
Member

jsimnz commented Feb 14, 2024

Describe the problem
There are various directives that aren't defined within the GQL schema. They do still get parsed, but the directive definition should exist on the GQL schema.

Specific directives:

We can see all the directives correctly defined in request/graphql/schema/types.go with their various gql.NewDirective call but they don't get registered into the defaultDirectivesType() function

func defaultDirectivesType() []*gql.Directive {

Additionally, the @crdt directive isn't defined at all, it only exists within the AST parsing code of fieldsFromAST function

cType, err := setCRDTType(field, kind)

@jsimnz jsimnz added bug Something isn't working area/query Related to the query component labels Feb 14, 2024
@fredcarle fredcarle added this to the DefraDB v0.10 milestone Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/query Related to the query component bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants