-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Control benchmark types through labels #267
Conversation
f191795
to
2d53b48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Although I recommend including the 'Usage' documentation as part of the yaml to locate the information near the code and avoid having to refer to the PR for it.
I think this can be merged as is, and the documentation can go into the eventual CONTRIBUTION doc before open sourcing, |
2d53b48
to
72f4237
Compare
098a05b
to
de90544
Compare
Codecov Report
@@ Coverage Diff @@
## develop #267 +/- ##
===========================================
- Coverage 62.37% 58.28% -4.10%
===========================================
Files 84 103 +19
Lines 9245 10200 +955
===========================================
+ Hits 5767 5945 +178
- Misses 2871 3622 +751
- Partials 607 633 +26
|
DESCRIPTION: This PR enables picking the type of benchmarks we want to run on our first commit (the one that PR is opened with) or controlling the benchmarks we want to run on our next commit on that PR. USAGE: The two labels we can use at the moment are: `action/no-benchmark` and `action/full-benchmark`. If PR has following labels, here is what it will do: * Label(s) = [`action/no-benchmark`] > No benchmarks will be ran. * Label(s) = [`action/full-benchmark`] > All the benchmarks will be ran. * Label(s) = [`action/no-benchmark` and `action/full-benchmark`] > `action/no-benchmark` takes precedence therefore, no benchmarks will be ran. * Label(s) = [] (no label provided) > Partial / short benchmarks will be ran.
DESCRIPTION:
This PR enables picking the type of benchmarks we want to run on our first commit (the one that PR is opened with) or controlling the benchmarks we want to run on our next commit on that PR.
USAGE:
The two labels we can use at the moment are:
action/no-benchmark
andaction/full-benchmark
.If PR has following labels, here is what it will do:
action/no-benchmark
]action/full-benchmark
]action/no-benchmark
andaction/full-benchmark
]FUTURE:
This is the last PR that was blocking the benchmark comparisons.