Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Control benchmark types through labels #267

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

shahzadlone
Copy link
Member

@shahzadlone shahzadlone commented Mar 4, 2022

DESCRIPTION:

This PR enables picking the type of benchmarks we want to run on our first commit (the one that PR is opened with) or controlling the benchmarks we want to run on our next commit on that PR.

USAGE:

The two labels we can use at the moment are: action/no-benchmark and action/full-benchmark.

If PR has following labels, here is what it will do:

  • Label(s) = [action/no-benchmark]

No benchmarks will be ran.

  • Label(s) = [action/full-benchmark]

All the benchmarks will be ran.

  • Label(s) = [action/no-benchmark and action/full-benchmark]

action/no-benchmark takes precedence therefore, no benchmarks will be ran.

  • Label(s) = [] (no label provided)

Partial / short benchmarks will be ran.

FUTURE:

This is the last PR that was blocking the benchmark comparisons.

@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label Mar 4, 2022
@shahzadlone shahzadlone self-assigned this Mar 4, 2022
@shahzadlone shahzadlone added action/full-benchmark Runs the full / longer benchmark action. action/no-benchmark Skips the action that runs the benchmark. and removed action/no-benchmark Skips the action that runs the benchmark. action/full-benchmark Runs the full / longer benchmark action. labels Mar 4, 2022
@shahzadlone shahzadlone force-pushed the lone/ci/follow-labels branch from f191795 to 2d53b48 Compare March 4, 2022 10:59
@shahzadlone shahzadlone removed the action/full-benchmark Runs the full / longer benchmark action. label Mar 4, 2022
@shahzadlone shahzadlone linked an issue Mar 4, 2022 that may be closed by this pull request
Copy link
Member

@jsimnz jsimnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Copy link
Contributor

@orpheuslummis orpheuslummis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although I recommend including the 'Usage' documentation as part of the yaml to locate the information near the code and avoid having to refer to the PR for it.

@jsimnz
Copy link
Member

jsimnz commented Mar 7, 2022

I think this can be merged as is, and the documentation can go into the eventual CONTRIBUTION doc before open sourcing,

@shahzadlone shahzadlone added area/api Related to the external API component and removed action/no-benchmark Skips the action that runs the benchmark. labels Mar 8, 2022
@shahzadlone shahzadlone force-pushed the lone/ci/follow-labels branch from 2d53b48 to 72f4237 Compare March 8, 2022 16:52
@shahzadlone shahzadlone added action/no-benchmark Skips the action that runs the benchmark. area/testing Related to any test or testing suite ci/build This is issue is about the build or CI system, and the administration of it. and removed area/api Related to the external API component labels Mar 8, 2022
@shahzadlone shahzadlone force-pushed the lone/ci/follow-labels branch from 098a05b to de90544 Compare March 8, 2022 17:07
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #267 (098a05b) into develop (82b9468) will decrease coverage by 4.09%.
The diff coverage is n/a.

❗ Current head 098a05b differs from pull request most recent head de90544. Consider uploading reports for the commit de90544 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #267      +/-   ##
===========================================
- Coverage    62.37%   58.28%   -4.10%     
===========================================
  Files           84      103      +19     
  Lines         9245    10200     +955     
===========================================
+ Hits          5767     5945     +178     
- Misses        2871     3622     +751     
- Partials       607      633      +26     
Impacted Files Coverage Δ
db/tests/mutation/simple/utils.go 100.00% <0.00%> (ø)
bench/collection/utils.go 0.00% <0.00%> (ø)
bench/fixtures/fixtures.go 0.00% <0.00%> (ø)
db/tests/query/one_to_many_multiple/utils.go 100.00% <0.00%> (ø)
db/tests/query/simple/utils.go 100.00% <0.00%> (ø)
bench/storage/utils.go 0.00% <0.00%> (ø)
bench/bench_util.go 10.60% <0.00%> (ø)
db/tests/utils.go 33.89% <0.00%> (ø)
bench/query/simple/utils.go 0.00% <0.00%> (ø)
db/tests/query/inline_array/utils.go 100.00% <0.00%> (ø)
... and 9 more

@shahzadlone shahzadlone merged commit e32efe0 into develop Mar 8, 2022
@shahzadlone shahzadlone deleted the lone/ci/follow-labels branch March 8, 2022 17:17
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
DESCRIPTION:

This PR enables picking the type of benchmarks we want to run on our first commit (the one that PR is opened with) or controlling the benchmarks we want to run on our next commit on that PR.

USAGE:

The two labels we can use at the moment are: `action/no-benchmark` and `action/full-benchmark`.

If PR has following labels, here is what it will do:

* Label(s) = [`action/no-benchmark`]
> No benchmarks will be ran.

* Label(s) = [`action/full-benchmark`]
> All the benchmarks will be ran.

* Label(s) = [`action/no-benchmark` and `action/full-benchmark`]
> `action/no-benchmark` takes precedence therefore, no benchmarks will be ran.

* Label(s) = [] (no label provided)
> Partial / short benchmarks will be ran.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/testing Related to any test or testing suite ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add label to skip ci benchmarking that runs on aws
3 participants