Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update README Contributors section #292

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

jsimnz
Copy link
Member

@jsimnz jsimnz commented Mar 12, 2022

Credit where credit is due :)

To the team making this happen :)
@orpheuslummis
Copy link
Contributor

orpheuslummis commented Mar 12, 2022

Initially the Rust project had an AUTHORS.txt then a few years later removed it from the repo. It was probably getting unwidly. Now they have https://thanks.rust-lang.org/. Interestingly, https://thanks.rust-lang.org/about/ indicates they plan to "add tracking for more repositories under the Rust project generally, and possibly even tracking other kinds of contributions, as they're also important!".

A simple strategy is to have an AUTHORS file, e.g. https://github.com/ethereum/go-ethereum/blob/master/AUTHORS, and update it as part of the release process.

git log --format='%aN <%aE>' | sort -f | uniq to obtain list of names and emails from repo, although when a user changes their name it will double count them.

@orpheuslummis orpheuslummis added the action/no-benchmark Skips the action that runs the benchmark. label Mar 12, 2022
@jsimnz jsimnz added the meta/dev These issues related to the meta elements of the code base like dev flow, repo logistics, and PM label Mar 12, 2022
@jsimnz
Copy link
Member Author

jsimnz commented Mar 12, 2022

Initially the Rust project had an AUTHORS.txt then a few years later removed it from the repo. It was probably getting unwidly. Now they have https://thanks.rust-lang.org/. Interestingly, https://thanks.rust-lang.org/about/ indicates they plan to "add tracking for more repositories under the Rust project generally, and possibly even tracking other kinds of contributions, as they're also important!".

A simple strategy is to have an AUTHORS file, e.g. https://github.com/ethereum/go-ethereum/blob/master/AUTHORS, and update it as part of the release process.

git log --format='%aN <%aE>' | sort -f | uniq to obtain list of names and emails from repo, although when a user changes their name it will double count them.

Yea makes sense to put an AUTHORS file together, but for now just want to highlight ppl while its small

@jsimnz jsimnz merged commit 9263b5d into develop Mar 18, 2022
@jsimnz jsimnz deleted the jsimnz/chore/update-readme-contributors branch March 18, 2022 22:32
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. meta/dev These issues related to the meta elements of the code base like dev flow, repo logistics, and PM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants