fix: GraphQL null argument parsing

[nasdf]

Relevant issue(s)

Resolves #3012

Description

This PR fixes an issue where explicitly null GQL inputs would cause a panic.

Tasks

• I made sure the code is well commented, particularly hard-to-understand areas.
• I made sure the repository-held documentation is changed accordingly.
• I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
• I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Added tests

Specify the platform(s) on which this was tested:

• MacOS

[codecov]

Codecov Report

Attention: Patch coverage is 88.71795% with 22 lines in your changes missing coverage. Please review.

Project coverage is 79.33%. Comparing base (2675b2e) to head (555ee59).
Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
internal/request/graphql/parser/query.go	87.88%	6 Missing and 6 partials ⚠️
internal/request/graphql/parser/filter.go	69.23%	3 Missing and 1 partial ⚠️
internal/request/graphql/parser/commit.go	94.29%	1 Missing and 1 partial ⚠️
internal/request/graphql/parser/mutation.go	94.29%	1 Missing and 1 partial ⚠️
internal/request/graphql/parser/subscription.go	50.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3013      +/-   ##
===========================================
- Coverage    79.37%   79.33%   -0.04%     
===========================================
  Files          333      333              
  Lines        25766    25822      +56     
===========================================
+ Hits         20451    20485      +34     
- Misses        3855     3866      +11     
- Partials      1460     1471      +11     

Flag	Coverage Δ
all-tests	79.33% <88.72%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
internal/planner/mapper/targetable.go	78.67% <100.00%> (+0.89%)	⬆️
internal/request/graphql/parser/commit.go	87.30% <94.29%> (+0.07%)	⬆️
internal/request/graphql/parser/mutation.go	86.84% <94.29%> (-0.66%)	⬇️
internal/request/graphql/parser/subscription.go	79.31% <50.00%> (-6.90%)	⬇️
internal/request/graphql/parser/filter.go	68.27% <69.23%> (-0.42%)	⬇️
internal/request/graphql/parser/query.go	86.24% <87.88%> (-3.11%)	⬇️

... and 14 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2675b2e...555ee59. Read the comment docs.

[AndrewSisley]

Looks good to me Keenan, thanks for sorting this out so quickly. Approving now, but have a tiny todo and a question for you before merge please :)

[AndrewSisley]

todo: This looks like it was accidentally left in after debugging - can it be reverted?

[nasdf]

This line was causing a panic when the property value is nil. Is there a different way I should be handling the nil value here?

[AndrewSisley]

Ah I see. I would prefer a if v != nil wrapper then - it is a much stronger declaration of intent.

[nasdf]

done

[AndrewSisley]

question: input is not nillable? (I don't see any tests for that)

[nasdf]

nice catch! added a test

[AndrewSisley]

priase: Thanks for all theses tests Keenan, looks good :)