Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to defradb/errors.Join from stdlib/errors.Join #3334

Open
fredcarle opened this issue Dec 18, 2024 · 0 comments · May be fixed by #3343
Open

Switch to defradb/errors.Join from stdlib/errors.Join #3334

fredcarle opened this issue Dec 18, 2024 · 0 comments · May be fixed by #3343
Assignees
Labels
area/errors Related to the internal management or design of our error handling system good first issue Good for newcomers
Milestone

Comments

@fredcarle
Copy link
Collaborator

fredcarle commented Dec 18, 2024

Some devs have started using Join from the std lib errors package. This will eventually cause us to import both the std lib errors and Defra's errors packages in the same file. Lets add Join to Defra errors to avoid this.

Edit: It's already part of Defra's errors package so we should switch out where we use stdlib/errors.Join for defradb/errors.Join.

@fredcarle fredcarle added area/errors Related to the internal management or design of our error handling system good first issue Good for newcomers labels Dec 18, 2024
@ChrisBQu ChrisBQu self-assigned this Dec 20, 2024
@ChrisBQu ChrisBQu added this to the DefraDB v0.16 milestone Dec 20, 2024
@ChrisBQu ChrisBQu removed their assignment Dec 20, 2024
@fredcarle fredcarle changed the title Add Join to the Defra errors package. Switch to defradb/errors.Join from stdlib/errors.Join Dec 20, 2024
@ChrisBQu ChrisBQu self-assigned this Dec 20, 2024
@ChrisBQu ChrisBQu linked a pull request Dec 23, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/errors Related to the internal management or design of our error handling system good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants