Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Configurable caller option of logger #416

Merged
merged 1 commit into from
May 8, 2022
Merged

feat: Configurable caller option of logger #416

merged 1 commit into from
May 8, 2022

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented May 6, 2022 •
edited
Loading

Adds the EnableCaller option to the logger configuration. Disables it by default for a more readable default log output.

The reasoning is that usual users of defradb don't benefit from the code file & line number information.

A short subsequent PR will make it configurable via config file, CLI flag, env. variable, after #389 merges.

from

2022-05-06T10:45:21.851-0400, INFO, defra.cli, cmd/start.go:58, Starting DefraDB process...
2022-05-06T10:45:21.851-0400, INFO, defra.cli, cmd/start.go:68, opening badger store, {"Path": "/Users/o/.defradb/data"}
2022-05-06T10:45:21.887-0400, INFO, defra.cli, cmd/start.go:104, Starting P2P node, {"tcp address": "/ip4/0.0.0.0/tcp/9161"}
2022-05-06T10:45:21.890-0400, INFO, defra.node, node/node.go:110, Created LibP2P host, {"PeerId": "12D3KooWAsGqxLjQTxzHebhgziT8B4147grxqGAzddC2sXTk4YFX", "Address": ["/ip4/0.0.0.0/tcp/9171"]}

going to

2022-05-06T10:44:54.922-0400, INFO, defra.cli, Starting DefraDB process...
2022-05-06T10:44:54.922-0400, INFO, defra.cli, opening badger store, {"Path": "/Users/o/.defradb/data"}
2022-05-06T10:44:54.946-0400, INFO, defra.cli, Starting P2P node, {"tcp address": "/ip4/0.0.0.0/tcp/9161"}
2022-05-06T10:44:54.950-0400, INFO, defra.node, Created LibP2P host, {"PeerId": "12D3KooWAsGqxLjQTxzHebhgziT8B4147grxqGAzddC2sXTk4YFX", "Address": ["/ip4/0.0.0.0/tcp/9171"]}

@orpheuslummis orpheuslummis added the area/logging Related to the logging/logger system label May 6, 2022
@orpheuslummis orpheuslummis self-assigned this May 6, 2022
@orpheuslummis orpheuslummis changed the title feat: configurable caller option in logger feat: Configurable caller option in logger May 6, 2022
@orpheuslummis orpheuslummis changed the title feat: Configurable caller option in logger feat: Configurable caller option of logger May 6, 2022
@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 70 Benchmarks were ✅ Better.
  • 43 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_Read_Async_10_10-4365µs ± 0%289µs ± 0%−20.99%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-412.8ms ± 0%10.3ms ± 0%−19.21%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4602µs ± 0%535µs ± 0%−11.13%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.77ms ± 0%1.61ms ± 0%−8.83%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-413.0ms ± 0%10.8ms ± 0%−16.92%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4491µs ± 0%464µs ± 0%−5.47%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4382µs ± 0%330µs ± 0%−13.62%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4337µs ± 0%323µs ± 0%−4.23%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4295µs ± 0%289µs ± 0%−2.02%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4520µs ± 0%471µs ± 0%−9.52%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.68ms ± 0%1.55ms ± 0%−7.61%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-415.1ms ± 0%12.7ms ± 0%−15.71%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-418.3µs ± 0%14.8µs ± 0%−19.07%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-419.3µs ± 0%16.8µs ± 0%−12.80%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-420.5µs ± 0%16.7µs ± 0%−18.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-425.9µs ± 0%20.9µs ± 0%−19.12%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4176µs ± 0%142µs ± 0%−19.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4168µs ± 0%155µs ± 0%−8.19%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4213µs ± 0%171µs ± 0%−19.75%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4244µs ± 0%206µs ± 0%−15.61%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4303µs ± 0%267µs ± 0%−11.70%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-419.2µs ± 0%16.3µs ± 0%−15.23%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-418.8µs ± 0%16.8µs ± 0%−10.50%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-421.3µs ± 0%17.6µs ± 0%−17.48%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-423.9µs ± 0%20.6µs ± 0%−13.98%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-427.0µs ± 0%24.6µs ± 0%−8.80%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4168µs ± 0%155µs ± 0%−7.59%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4177µs ± 0%167µs ± 0%−5.77%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4190µs ± 0%179µs ± 0%−5.85%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4258µs ± 0%227µs ± 0%−12.01%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-458.4µs ± 0%53.5µs ± 0%−8.36%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-460.5µs ± 0%56.7µs ± 0%−6.33%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-457.0µs ± 0%54.1µs ± 0%−5.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-457.6µs ± 0%52.2µs ± 0%−9.33%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-463.6µs ± 0%62.8µs ± 0%−1.36%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-476.6µs ± 0%72.3µs ± 0%−5.62%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4441µs ± 0%399µs ± 0%−9.56%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4481µs ± 0%471µs ± 0%−2.21%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4681µs ± 0%546µs ± 0%−19.74%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4132µs ± 0%131µs ± 0%−0.69%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4148µs ± 0%143µs ± 0%−3.55%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4142µs ± 0%133µs ± 0%−6.22%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4163µs ± 0%135µs ± 0%−17.42%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4163µs ± 0%150µs ± 0%−7.45%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.45ms ± 0%1.33ms ± 0%−7.93%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.41ms ± 0%1.30ms ± 0%−7.68%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.75ms ± 0%1.52ms ± 0%−13.20%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4193µs ± 0%119µs ± 0%−38.39%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4163µs ± 0%124µs ± 0%−24.44%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4152µs ± 0%123µs ± 0%−19.32%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4199µs ± 0%130µs ± 0%−34.74%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4210µs ± 0%142µs ± 0%−32.35%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.53ms ± 0%1.29ms ± 0%−15.78%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.34ms ± 0%1.32ms ± 0%−1.21%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.52ms ± 0%1.35ms ± 0%−11.38%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.55ms ± 0%1.24ms ± 0%−20.05%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.80ms ± 0%1.38ms ± 0%−23.37%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-411.0µs ± 0%8.1µs ± 0%−26.45%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-411.7µs ± 0%9.8µs ± 0%−16.56%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-411.4µs ± 0%9.6µs ± 0%−15.69%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-412.6µs ± 0%12.0µs ± 0%−4.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-416.2µs ± 0%16.1µs ± 0%−1.09%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4146µs ± 0%117µs ± 0%−19.59%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4190µs ± 0%154µs ± 0%−19.01%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4134µs ± 0%127µs ± 0%−5.56%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4133µs ± 0%127µs ± 0%−4.18%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.36ms ± 0%1.31ms ± 0%−3.58%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.38ms ± 0%1.33ms ± 0%−3.68%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.44ms ± 0%1.40ms ± 0%−3.04%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.40ms ± 0%1.38ms ± 0%−2.01%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4294ms ± 0%317ms ± 0%+7.63%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-410.5ms ± 0%14.9ms ± 0%+41.52%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4102ms ± 0%128ms ± 0%+25.26%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.03s ± 0%1.31s ± 0%+27.49%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-445.9ms ± 0%54.7ms ± 0%+19.15%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4438ms ± 0%475ms ± 0%+8.38%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.63s ± 0%4.86s ± 0%+4.83%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4382µs ± 0%383µs ± 0%+0.36%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.74ms ± 0%4.37ms ± 0%+16.81%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-439.3ms ± 0%41.7ms ± 0%+6.25%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4372µs ± 0%379µs ± 0%+1.67%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.74ms ± 0%4.27ms ± 0%+14.05%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.81ms ± 0%1.98ms ± 0%+9.08%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-423.9ms ± 0%25.2ms ± 0%+5.49%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4255µs ± 0%270µs ± 0%+5.76%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.83ms ± 0%1.90ms ± 0%+3.43%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.28ms ± 0%1.36ms ± 0%+6.34%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4482µs ± 0%489µs ± 0%+1.60%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4583µs ± 0%784µs ± 0%+34.46%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4784µs ± 0%812µs ± 0%+3.58%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4762µs ± 0%772µs ± 0%+1.31%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4678µs ± 0%724µs ± 0%+6.79%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4188µs ± 0%202µs ± 0%+7.38%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-458.1µs ± 0%59.1µs ± 0%+1.84%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-456.9µs ± 0%58.1µs ± 0%+2.18%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-455.1µs ± 0%74.0µs ± 0%+34.19%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-468.3µs ± 0%85.0µs ± 0%+24.35%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4386µs ± 0%468µs ± 0%+21.18%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4372µs ± 0%477µs ± 0%+28.02%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4366µs ± 0%538µs ± 0%+46.98%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4407µs ± 0%620µs ± 0%+52.25%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4502µs ± 0%653µs ± 0%+30.24%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4403µs ± 0%419µs ± 0%+3.94%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4421µs ± 0%425µs ± 0%+0.87%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.35ms ± 0%1.41ms ± 0%+3.81%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.34ms ± 0%1.36ms ± 0%+2.09%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-492.3µs ± 0%96.0µs ± 0%+4.00%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4105µs ± 0%122µs ± 0%+17.06%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4100µs ± 0%115µs ± 0%+14.55%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4137µs ± 0%139µs ± 0%+1.49%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4128µs ± 0%134µs ± 0%+4.40%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4137µs ± 0%139µs ± 0%+1.63%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.30ms ± 0%1.38ms ± 0%+6.41%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:github.com/sourcenetwork/defradb/bench/collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-411.3ms ± 0%11.5ms ± 0%+2.00%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4294ms ± 0%317ms ± 0%+7.63%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-410.5ms ± 0%14.9ms ± 0%+41.52%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4102ms ± 0%128ms ± 0%+25.26%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.03s ± 0%1.31s ± 0%+27.49%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-445.9ms ± 0%54.7ms ± 0%+19.15%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4438ms ± 0%475ms ± 0%+8.38%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.63s ± 0%4.86s ± 0%+4.83%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4382µs ± 0%383µs ± 0%+0.36%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-43.74ms ± 0%4.37ms ± 0%+16.81%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-439.3ms ± 0%41.7ms ± 0%+6.25%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4372µs ± 0%379µs ± 0%+1.67%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-43.74ms ± 0%4.27ms ± 0%+14.05%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4365µs ± 0%289µs ± 0%−20.99%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.81ms ± 0%1.98ms ± 0%+9.08%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-423.9ms ± 0%25.2ms ± 0%+5.49%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4255µs ± 0%270µs ± 0%+5.76%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.83ms ± 0%1.90ms ± 0%+3.43%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4384µs ± 0%373µs ± 0%−2.87%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.28ms ± 0%1.36ms ± 0%+6.34%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-412.8ms ± 0%10.3ms ± 0%−19.21%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4602µs ± 0%535µs ± 0%−11.13%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.77ms ± 0%1.61ms ± 0%−8.83%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-413.0ms ± 0%10.8ms ± 0%−16.92%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4482µs ± 0%489µs ± 0%+1.60%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4583µs ± 0%784µs ± 0%+34.46%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4491µs ± 0%464µs ± 0%−5.47%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4784µs ± 0%812µs ± 0%+3.58%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4762µs ± 0%772µs ± 0%+1.31%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4678µs ± 0%724µs ± 0%+6.79%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4382µs ± 0%330µs ± 0%−13.62%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4337µs ± 0%323µs ± 0%−4.23%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4295µs ± 0%289µs ± 0%−2.02%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4520µs ± 0%471µs ± 0%−9.52%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.68ms ± 0%1.55ms ± 0%−7.61%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-415.1ms ± 0%12.7ms ± 0%−15.71%(p=1.000 n=1+1)
pkg:github.com/sourcenetwork/defradb/bench/storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-417.2µs ± 0%14.4µs ± 0%−16.08%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-418.3µs ± 0%14.8µs ± 0%−19.07%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-419.3µs ± 0%16.8µs ± 0%−12.80%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-420.5µs ± 0%16.7µs ± 0%−18.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-425.9µs ± 0%20.9µs ± 0%−19.12%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4176µs ± 0%142µs ± 0%−19.55%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4168µs ± 0%155µs ± 0%−8.19%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4213µs ± 0%171µs ± 0%−19.75%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4244µs ± 0%206µs ± 0%−15.61%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4303µs ± 0%267µs ± 0%−11.70%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-419.2µs ± 0%16.3µs ± 0%−15.23%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-418.8µs ± 0%16.8µs ± 0%−10.50%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-421.3µs ± 0%17.6µs ± 0%−17.48%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-423.9µs ± 0%20.6µs ± 0%−13.98%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-427.0µs ± 0%24.6µs ± 0%−8.80%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4168µs ± 0%155µs ± 0%−7.59%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4177µs ± 0%167µs ± 0%−5.77%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4190µs ± 0%179µs ± 0%−5.85%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4188µs ± 0%202µs ± 0%+7.38%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4258µs ± 0%227µs ± 0%−12.01%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-458.4µs ± 0%53.5µs ± 0%−8.36%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-458.1µs ± 0%59.1µs ± 0%+1.84%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-456.9µs ± 0%58.1µs ± 0%+2.18%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-455.1µs ± 0%74.0µs ± 0%+34.19%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-468.3µs ± 0%85.0µs ± 0%+24.35%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4386µs ± 0%468µs ± 0%+21.18%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4372µs ± 0%477µs ± 0%+28.02%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4366µs ± 0%538µs ± 0%+46.98%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4407µs ± 0%620µs ± 0%+52.25%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4502µs ± 0%653µs ± 0%+30.24%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-460.5µs ± 0%56.7µs ± 0%−6.33%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-457.0µs ± 0%54.1µs ± 0%−5.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-457.6µs ± 0%52.2µs ± 0%−9.33%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-463.6µs ± 0%62.8µs ± 0%−1.36%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-476.6µs ± 0%72.3µs ± 0%−5.62%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4403µs ± 0%419µs ± 0%+3.94%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4421µs ± 0%425µs ± 0%+0.87%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4441µs ± 0%399µs ± 0%−9.56%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4481µs ± 0%471µs ± 0%−2.21%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4681µs ± 0%546µs ± 0%−19.74%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4132µs ± 0%131µs ± 0%−0.69%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4148µs ± 0%143µs ± 0%−3.55%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4142µs ± 0%133µs ± 0%−6.22%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4163µs ± 0%135µs ± 0%−17.42%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4163µs ± 0%150µs ± 0%−7.45%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.35ms ± 0%1.41ms ± 0%+3.81%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.45ms ± 0%1.33ms ± 0%−7.93%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.34ms ± 0%1.36ms ± 0%+2.09%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.41ms ± 0%1.30ms ± 0%−7.68%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.75ms ± 0%1.52ms ± 0%−13.20%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4193µs ± 0%119µs ± 0%−38.39%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4163µs ± 0%124µs ± 0%−24.44%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4152µs ± 0%123µs ± 0%−19.32%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4199µs ± 0%130µs ± 0%−34.74%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4210µs ± 0%142µs ± 0%−32.35%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.53ms ± 0%1.29ms ± 0%−15.78%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.34ms ± 0%1.32ms ± 0%−1.21%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.52ms ± 0%1.35ms ± 0%−11.38%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.55ms ± 0%1.24ms ± 0%−20.05%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.80ms ± 0%1.38ms ± 0%−23.37%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-411.0µs ± 0%8.1µs ± 0%−26.45%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-411.7µs ± 0%9.8µs ± 0%−16.56%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-411.4µs ± 0%9.6µs ± 0%−15.69%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-412.6µs ± 0%12.0µs ± 0%−4.62%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-416.2µs ± 0%16.1µs ± 0%−1.09%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-492.3µs ± 0%96.0µs ± 0%+4.00%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-4105µs ± 0%122µs ± 0%+17.06%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4100µs ± 0%115µs ± 0%+14.55%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4146µs ± 0%117µs ± 0%−19.59%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4190µs ± 0%154µs ± 0%−19.01%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4137µs ± 0%139µs ± 0%+1.49%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4134µs ± 0%127µs ± 0%−5.56%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4133µs ± 0%127µs ± 0%−4.18%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4128µs ± 0%134µs ± 0%+4.40%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4137µs ± 0%139µs ± 0%+1.63%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.36ms ± 0%1.31ms ± 0%−3.58%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.38ms ± 0%1.33ms ± 0%−3.68%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.30ms ± 0%1.38ms ± 0%+6.41%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.44ms ± 0%1.40ms ± 0%−3.04%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.40ms ± 0%1.38ms ± 0%−2.01%(p=1.000 n=1+1)
 

@orpheuslummis
Copy link
Contributor Author

closes #417

@orpheuslummis orpheuslummis linked an issue May 6, 2022 that may be closed by this pull request
Configurable caller option of logger #417
Closed
@orpheuslummis orpheuslummis added this to the DefraDB v0.3 milestone May 6, 2022
AndrewSisley
AndrewSisley approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, and I like the functionality change

logging/config.go Show resolved Hide resolved
fredcarle
fredcarle approved these changes May 8, 2022
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this :) Thanks for implementing.

@orpheuslummis orpheuslummis merged commit 6d41b10 into develop May 8, 2022
@orpheuslummis orpheuslummis deleted the orpheus/feat/logging-caller-option branch May 8, 2022 16:35
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
feat: Configurable caller option in logger (sourcenetwork#416)
8f2c2d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewSisley AndrewSisley AndrewSisley approved these changes

@fredcarle fredcarle fredcarle approved these changes

@shahzadlone shahzadlone Awaiting requested review from shahzadlone

Assignees

@orpheuslummis orpheuslummis

Labels
area/logging Related to the logging/logger system
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Configurable caller option of logger
4 participants
@orpheuslummis @source-devs @fredcarle @AndrewSisley