-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: Add test coverage html output #466
Conversation
5409af2
to
5222a50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some comments, most notable is the path
inconsistency between macos and linux.
I generally think of test:
commit label as when we add tests to the code. i.e. integration tests or unit tests. For stuff related to code coverage, make
rules and these "external" tasks I like to use tools :
label in the title.
I think it was just a usage issue for the Thanks for clarifying. I'll change it to |
- RELEVANT ISSUE(S) Resolves sourcenetwork#466 - DESCRIPTION Instead of relying on codecov to inspect our code coverage, we can do it locally using -coverprofile. This PR adds a make command to simplify the process.
RELEVANT ISSUE(S)
Resolves #465
DESCRIPTION
Instead of relying on codecov to inspect our code coverage, we can do it locally using
-coverprofile
. This PR adds amake
command to simplify the process.HOW HAS THIS BEEN TESTED?
This was tested by running the new
make
command and insuring that the html output was displayed and that temporary files were cleaned up.make test:coverage-html path="./api/..."
CHECKLIST:
ENVIRONMENT / OS THIS WAS TESTED ON?
Please specify which of the following was this tested on (remove or add your own):