feat: Add ability to explain updateNode attributes.
#514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
feature
shahzadlone
requested review from
orpheuslummis,
jsimnz,
fredcarle,
Lodek and
AndrewSisley
shahzadlone
added
the
action/no-benchmark
shahzadlone
force-pushed
the
lone/feat/explain-update-node-attributes
branch
2 times, most recently
from
6e49eda to
e4ba64a
Compare
|
Looks like you are missing the selects and stuff? If you change to: You should get all of the other stuff |
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results...
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Codecov Report
@@ Coverage Diff @@
## develop #514 +/- ##
===========================================
+ Coverage 54.32% 54.41% +0.09%
===========================================
Files 97 97
Lines 13158 13176 +18
===========================================
+ Hits 7148 7170 +22
+ Misses 5331 5327 -4
Partials 679 679
|
shahzadlone
force-pushed
the
lone/feat/explain-update-node-attributes
branch
from
2e6f67d to
630ad06
Compare
AndrewSisley
approved these changes
Jun 10, 2022
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
) - Resolves sourcenetwork#483 - Add the attributes for `updateNode` that we want to see in the explainable response. Request: ``` mutation @Explain { update_user( ids: [ "bae-0a24cf29-b2c2-5861-9d00-abd6250c475d", "bae-958c9334-73cf-5695-bf06-cf06826babfa" ], data: "{\"points\": 59}" ) { _key name points } } ``` Response: ``` "explain": { "updateNode": { "data": { "points": float64(59), } "filter": nil, "ids": []string{ "bae-0a24cf29-b2c2-5861-9d00-abd6250c475d", "bae-958c9334-73cf-5695-bf06-cf06826babfa", } "selectTopNode": { "renderNode": { "selectNode": { "filter": nil, "scanNode": { "collectionID": "1", "collectionName": "user", "filter": nil, "spans": []{}, } } } } } } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEVANT ISSUE(S)
Resolves #483
DESCRIPTION
Add the attributes for
updatenode that we want to see in the explainable response.Request:
Response:
HOW HAS THIS BEEN TESTED?
Locally and Integration Tests
CHECKLIST:
ENVIRONMENT / OS THIS WAS TESTED ON?
Please specify which of the following was this tested on (remove or add your own):