feat: Explain cid & field attributes for dagScanNode
#598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
feature
shahzadlone
added
the
action/no-benchmark
Benchmark ResultsSummary
✅ See Better Results...
❌ See Worse Results...
✨ See Unchanged Results...
🐋 See Full Results...
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
AndrewSisley
approved these changes
Jul 7, 2022
| explainerMap["cid"] = nil | ||
| } | ||
|
|
||
| // Build the explaination of the spans attribute. | ||
| spansExplainer := []map[string]interface{}{} | ||
| // Note: n.headset is `nil` for single commit selection query, so must check for it. | ||
| if n.headset != nil && n.headset.spans.HasValue { |
There was a problem hiding this comment.
thought: For the future (not) now, it might be worth refactoring explain-spans at some point, as it would be good to help encourage consistency here across all nodes
There was a problem hiding this comment.
Agreed. Perhaps we can initiate a ticket to put any specific kind of refactor you might have in mind?
There was a problem hiding this comment.
Whatever you prefer, I probably wound't bother with a ticket and just do it as the first commit in the next explain PR
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…work#598) ## Relevant issue(s) Resolves sourcenetwork#597 ## Description Adds two more attributes to be included in the explain graph for `dagScanNode`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #597
Description
Adds two more attributes to be included in the explain graph for
dagScanNode.Tasks
How has this been tested?
CI and
make test(updated integration tests.)Specify the platform(s) on which this was tested: