fix: Error when attempting to insert value into relationship field #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
bug
AndrewSisley
commented
Jul 13, 2022
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestSaveErrorsGivenUnknownField(t *testing.T) { | ||
| func TestUpdateSaveErrorsGivenUnknownField(t *testing.T) { |
There was a problem hiding this comment.
Test also got renamed to distinguish it from the Create tests, I lazily showed this into the (first?) commit
AndrewSisley
force-pushed
the
sisley/fix/I105-one-many-insert
branch
from
adfd73c to
61d96ea
Compare
shahzadlone
reviewed
Jul 14, 2022
Comment on lines
24
to
29
| []byte( | ||
| `{ | ||
| "Name": "Painted House", | ||
| "Author": "ValueDoesntMatter" | ||
| }`, | ||
| ), |
There was a problem hiding this comment.
Suggested change
| []byte( | |
| `{ | |
| "Name": "Painted House", | |
| "Author": "ValueDoesntMatter" | |
| }`, | |
| ), | |
| []byte( | |
| `{ | |
| "Name": "Painted House", | |
| "Author": "ValueDoesntMatter" | |
| }`, | |
| ), |
Decouples them from thequery integration tests, allowing for a more focused interface and the removal of some complication from the query tests too.
AndrewSisley
force-pushed
the
sisley/fix/I105-one-many-insert
branch
from
61d96ea to
a995cad
Compare
AndrewSisley
force-pushed
the
sisley/fix/I105-one-many-insert
branch
from
a995cad to
8cf0cb0
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…ourcenetwork#632) * Simplify collection integration tests Decouples them from thequery integration tests, allowing for a more focused interface and the removal of some complication from the query tests too. * Error when trying to save value to relation field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #105
Description
Errors when attempting to insert value into relationship field instead of permitting the save (and then failing to read the relationship on query).
Also reworks the newish collection test framework - splitting it off from the query framework allowing both to be simplified. This does mean that collection tests will not go through the change-detector, and will only run against badger-IM - I don't see that as loss atm, but please discuss if you think otherwise.