Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Properly silence cobra errors #668

Merged
merged 2 commits into from
Jul 26, 2022
Merged

fix: Properly silence cobra errors #668

merged 2 commits into from
Jul 26, 2022

Conversation

orpheuslummis
Copy link
Contributor

@orpheuslummis orpheuslummis commented Jul 26, 2022 •
edited
Loading

Relevant issue(s)

Resolves #667

Description

Fixes the issue.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

Manual

Specify the platform(s) on which this was tested:

  • MacOS

@orpheuslummis orpheuslummis added bug Something isn't working area/cli Related to the CLI binary labels Jul 26, 2022
@orpheuslummis orpheuslummis added this to the DefraDB v0.3 milestone Jul 26, 2022
@orpheuslummis orpheuslummis requested a review from a team July 26, 2022 00:34
@orpheuslummis orpheuslummis self-assigned this Jul 26, 2022
fredcarle
fredcarle approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@source-devs
Copy link

Benchmark Results

Summary

  • 113 Benchmarks successfully compared.
  • 99 Benchmarks were ✅ Better.
  • 14 Benchmarks were ❌ Worse .
  • 0 Benchmarks were ✨ Unchanged.
✅ See Better Results...
time/opdelta
_Collection_UserSimple_CreateMany_Sync_0_100-4256ms ± 0%223ms ± 0%−13.07%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-410.7ms ± 0%9.9ms ± 0%−8.15%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4118ms ± 0%99ms ± 0%−16.29%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.28s ± 0%1.05s ± 0%−17.69%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-446.4ms ± 0%44.5ms ± 0%−4.19%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4454ms ± 0%445ms ± 0%−1.83%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.68s ± 0%4.46s ± 0%−4.74%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4479µs ± 0%347µs ± 0%−27.59%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-44.35ms ± 0%3.57ms ± 0%−17.82%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-441.9ms ± 0%38.9ms ± 0%−7.15%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4366µs ± 0%353µs ± 0%−3.61%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-44.43ms ± 0%3.87ms ± 0%−12.51%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4314µs ± 0%263µs ± 0%−16.24%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.91ms ± 0%1.84ms ± 0%−3.82%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.7ms ± 0%24.0ms ± 0%−2.84%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4298µs ± 0%255µs ± 0%−14.40%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.89ms ± 0%1.81ms ± 0%−4.38%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.33ms ± 0%1.13ms ± 0%−15.02%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-410.9ms ± 0%9.1ms ± 0%−16.63%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4596µs ± 0%441µs ± 0%−26.09%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.48ms ± 0%1.27ms ± 0%−14.18%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.1ms ± 0%9.2ms ± 0%−9.66%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4536µs ± 0%401µs ± 0%−25.11%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4694µs ± 0%460µs ± 0%−33.71%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4470µs ± 0%456µs ± 0%−2.91%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4878µs ± 0%672µs ± 0%−23.47%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4820µs ± 0%666µs ± 0%−18.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4716µs ± 0%642µs ± 0%−10.39%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4479µs ± 0%420µs ± 0%−12.27%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.34ms ± 0%1.25ms ± 0%−6.63%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-410.5ms ± 0%9.9ms ± 0%−5.83%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4340µs ± 0%297µs ± 0%−12.60%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4349µs ± 0%299µs ± 0%−14.31%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4307µs ± 0%306µs ± 0%−0.03%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-415.7µs ± 0%12.6µs ± 0%−19.41%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-415.1µs ± 0%14.4µs ± 0%−4.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-417.2µs ± 0%15.9µs ± 0%−7.38%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-421.6µs ± 0%19.5µs ± 0%−9.38%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4131µs ± 0%129µs ± 0%−1.38%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4139µs ± 0%132µs ± 0%−4.90%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4152µs ± 0%144µs ± 0%−4.98%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4178µs ± 0%158µs ± 0%−11.27%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4219µs ± 0%203µs ± 0%−7.33%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-415.7µs ± 0%15.2µs ± 0%−3.06%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.6µs ± 0%15.3µs ± 0%−1.77%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4152µs ± 0%144µs ± 0%−5.28%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4153µs ± 0%149µs ± 0%−2.33%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4174µs ± 0%168µs ± 0%−3.57%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-447.9µs ± 0%45.3µs ± 0%−5.51%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-450.4µs ± 0%44.4µs ± 0%−11.82%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-472.0µs ± 0%47.5µs ± 0%−34.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-461.6µs ± 0%54.7µs ± 0%−11.23%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-469.0µs ± 0%66.7µs ± 0%−3.39%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4402µs ± 0%351µs ± 0%−12.71%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4375µs ± 0%343µs ± 0%−8.41%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4381µs ± 0%367µs ± 0%−3.80%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4454µs ± 0%396µs ± 0%−12.65%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4528µs ± 0%483µs ± 0%−8.51%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-458.5µs ± 0%46.1µs ± 0%−21.22%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-454.7µs ± 0%43.6µs ± 0%−20.20%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-459.2µs ± 0%52.6µs ± 0%−11.17%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4380µs ± 0%344µs ± 0%−9.66%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4359µs ± 0%339µs ± 0%−5.64%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4417µs ± 0%363µs ± 0%−12.88%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4507µs ± 0%400µs ± 0%−21.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4568µs ± 0%494µs ± 0%−12.93%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4146µs ± 0%116µs ± 0%−20.63%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4132µs ± 0%118µs ± 0%−11.07%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4130µs ± 0%122µs ± 0%−5.79%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4144µs ± 0%129µs ± 0%−10.59%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4178µs ± 0%138µs ± 0%−22.85%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.37ms ± 0%1.15ms ± 0%−15.75%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.36ms ± 0%1.18ms ± 0%−13.02%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.30ms ± 0%1.20ms ± 0%−7.60%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.52ms ± 0%1.21ms ± 0%−20.66%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.71ms ± 0%1.38ms ± 0%−19.29%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4126µs ± 0%112µs ± 0%−11.70%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4139µs ± 0%113µs ± 0%−18.56%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4136µs ± 0%116µs ± 0%−14.59%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4143µs ± 0%122µs ± 0%−14.83%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4145µs ± 0%132µs ± 0%−8.77%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.17ms ± 0%1.12ms ± 0%−4.73%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.27ms ± 0%1.16ms ± 0%−8.62%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.24ms ± 0%1.17ms ± 0%−5.49%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.25ms ± 0%1.22ms ± 0%−2.60%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.51ms ± 0%1.35ms ± 0%−10.65%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.73µs ± 0%8.57µs ± 0%−1.79%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-49.24µs ± 0%8.58µs ± 0%−7.17%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-410.3µs ± 0%9.3µs ± 0%−9.47%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-412.1µs ± 0%11.1µs ± 0%−8.12%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-415.2µs ± 0%15.0µs ± 0%−0.96%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4103µs ± 0%86µs ± 0%−16.28%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-492.2µs ± 0%91.1µs ± 0%−1.16%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4102µs ± 0%96µs ± 0%−6.35%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4139µs ± 0%115µs ± 0%−17.15%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4164µs ± 0%150µs ± 0%−8.65%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4128µs ± 0%125µs ± 0%−2.24%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.22ms ± 0%1.20ms ± 0%−1.34%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.19ms ± 0%1.18ms ± 0%−1.22%(p=1.000 n=1+1)
 
❌ See Worse Results...
time/opdelta
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-415.5µs ± 0%16.1µs ± 0%+3.70%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-417.6µs ± 0%17.7µs ± 0%+0.84%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-420.7µs ± 0%21.1µs ± 0%+2.21%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4136µs ± 0%138µs ± 0%+1.73%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4202µs ± 0%205µs ± 0%+1.34%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-448.3µs ± 0%48.4µs ± 0%+0.10%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-466.4µs ± 0%68.2µs ± 0%+2.64%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4116µs ± 0%123µs ± 0%+5.75%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4125µs ± 0%126µs ± 0%+0.83%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4118µs ± 0%130µs ± 0%+9.82%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4118µs ± 0%126µs ± 0%+6.74%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.16ms ± 0%1.22ms ± 0%+4.86%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.19ms ± 0%1.23ms ± 0%+3.75%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.24ms ± 0%1.28ms ± 0%+3.55%(p=1.000 n=1+1)
 
✨ See Unchanged Results...
time/opdelta
 
🐋 See Full Results...
develop.txtcurrent.txt
time/opdelta
pkg:collection goos:linux goarch:amd64
_Collection_UserSimple_CreateMany_Sync_0_10-411.4ms ± 0%10.5ms ± 0%−7.51%(p=1.000 n=1+1)
_Collection_UserSimple_CreateMany_Sync_0_100-4256ms ± 0%223ms ± 0%−13.07%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_10-410.7ms ± 0%9.9ms ± 0%−8.15%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_100-4118ms ± 0%99ms ± 0%−16.29%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Sync_0_1000-41.28s ± 0%1.05s ± 0%−17.69%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_100-446.4ms ± 0%44.5ms ± 0%−4.19%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_1000-4454ms ± 0%445ms ± 0%−1.83%(p=1.000 n=1+1)
_Collection_UserSimple_Create_Async_0_10000-44.68s ± 0%4.46s ± 0%−4.74%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_10_10-4479µs ± 0%347µs ± 0%−27.59%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_100_100-44.35ms ± 0%3.57ms ± 0%−17.82%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_1000-441.9ms ± 0%38.9ms ± 0%−7.15%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_10-4366µs ± 0%353µs ± 0%−3.61%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Sync_1000_100-44.43ms ± 0%3.87ms ± 0%−12.51%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_10_10-4314µs ± 0%263µs ± 0%−16.24%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_100_100-41.91ms ± 0%1.84ms ± 0%−3.82%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_1000-424.7ms ± 0%24.0ms ± 0%−2.84%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_10-4298µs ± 0%255µs ± 0%−14.40%(p=1.000 n=1+1)
_Collection_UserSimple_Read_Async_1000_100-41.89ms ± 0%1.81ms ± 0%−4.38%(p=1.000 n=1+1)
pkg:query/simple goos:linux goarch:amd64
_Query_UserSimple_Query_Sync_10-4437µs ± 0%369µs ± 0%−15.47%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_100-41.33ms ± 0%1.13ms ± 0%−15.02%(p=1.000 n=1+1)
_Query_UserSimple_Query_Sync_1000-410.9ms ± 0%9.1ms ± 0%−16.63%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_10-4596µs ± 0%441µs ± 0%−26.09%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_100-41.48ms ± 0%1.27ms ± 0%−14.18%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithFilter_Sync_1000-410.1ms ± 0%9.2ms ± 0%−9.66%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_10-4536µs ± 0%401µs ± 0%−25.11%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_100-4694µs ± 0%460µs ± 0%−33.71%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithLimitOffset_Sync_1000-4470µs ± 0%456µs ± 0%−2.91%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_10-4878µs ± 0%672µs ± 0%−23.47%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_100-4820µs ± 0%666µs ± 0%−18.68%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithMultiLookup_Sync_1000-4716µs ± 0%642µs ± 0%−10.39%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_10-4479µs ± 0%420µs ± 0%−12.27%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_100-41.34ms ± 0%1.25ms ± 0%−6.63%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSort_Sync_1000-410.5ms ± 0%9.9ms ± 0%−5.83%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_10-4340µs ± 0%297µs ± 0%−12.60%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_100-4349µs ± 0%299µs ± 0%−14.31%(p=1.000 n=1+1)
_Query_UserSimple_Query_WithSingleLookup_Sync_1000-4307µs ± 0%306µs ± 0%−0.03%(p=1.000 n=1+1)
pkg:storage goos:linux goarch:amd64
_Storage_Simple_Read_Sync_1_10/ValueSize:0064-414.0µs ± 0%13.0µs ± 0%−7.49%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0128-415.7µs ± 0%12.6µs ± 0%−19.41%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0256-415.1µs ± 0%14.4µs ± 0%−4.54%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:0512-417.2µs ± 0%15.9µs ± 0%−7.38%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_10/ValueSize:1024-421.6µs ± 0%19.5µs ± 0%−9.38%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0064-4131µs ± 0%129µs ± 0%−1.38%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0128-4139µs ± 0%132µs ± 0%−4.90%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0256-4152µs ± 0%144µs ± 0%−4.98%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:0512-4178µs ± 0%158µs ± 0%−11.27%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_1_100/ValueSize:1024-4219µs ± 0%203µs ± 0%−7.33%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0064-415.5µs ± 0%16.1µs ± 0%+3.70%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0128-415.7µs ± 0%15.2µs ± 0%−3.06%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0256-415.6µs ± 0%15.3µs ± 0%−1.77%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:0512-417.6µs ± 0%17.7µs ± 0%+0.84%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_10/ValueSize:1024-420.7µs ± 0%21.1µs ± 0%+2.21%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0064-4136µs ± 0%138µs ± 0%+1.73%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0128-4152µs ± 0%144µs ± 0%−5.28%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0256-4153µs ± 0%149µs ± 0%−2.33%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:0512-4174µs ± 0%168µs ± 0%−3.57%(p=1.000 n=1+1)
_Storage_Simple_Read_Sync_100_100/ValueSize:1024-4202µs ± 0%205µs ± 0%+1.34%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0064-447.9µs ± 0%45.3µs ± 0%−5.51%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0128-450.4µs ± 0%44.4µs ± 0%−11.82%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0256-472.0µs ± 0%47.5µs ± 0%−34.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:0512-461.6µs ± 0%54.7µs ± 0%−11.23%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_10/ValueSize:1024-469.0µs ± 0%66.7µs ± 0%−3.39%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0064-4402µs ± 0%351µs ± 0%−12.71%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0128-4375µs ± 0%343µs ± 0%−8.41%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0256-4381µs ± 0%367µs ± 0%−3.80%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:0512-4454µs ± 0%396µs ± 0%−12.65%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_0_100/ValueSize:1024-4528µs ± 0%483µs ± 0%−8.51%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0064-458.5µs ± 0%46.1µs ± 0%−21.22%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0128-454.7µs ± 0%43.6µs ± 0%−20.20%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0256-448.3µs ± 0%48.4µs ± 0%+0.10%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:0512-459.2µs ± 0%52.6µs ± 0%−11.17%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_10/ValueSize:1024-466.4µs ± 0%68.2µs ± 0%+2.64%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0064-4380µs ± 0%344µs ± 0%−9.66%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0128-4359µs ± 0%339µs ± 0%−5.64%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0256-4417µs ± 0%363µs ± 0%−12.88%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:0512-4507µs ± 0%400µs ± 0%−21.08%(p=1.000 n=1+1)
_Storage_Simple_WriteMany_Sync_100_100/ValueSize:1024-4568µs ± 0%494µs ± 0%−12.93%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0064-4146µs ± 0%116µs ± 0%−20.63%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0128-4132µs ± 0%118µs ± 0%−11.07%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0256-4130µs ± 0%122µs ± 0%−5.79%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:0512-4144µs ± 0%129µs ± 0%−10.59%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_10/ValueSize:1024-4178µs ± 0%138µs ± 0%−22.85%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0064-41.37ms ± 0%1.15ms ± 0%−15.75%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0128-41.36ms ± 0%1.18ms ± 0%−13.02%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0256-41.30ms ± 0%1.20ms ± 0%−7.60%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:0512-41.52ms ± 0%1.21ms ± 0%−20.66%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_0_100/ValueSize:1024-41.71ms ± 0%1.38ms ± 0%−19.29%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0064-4126µs ± 0%112µs ± 0%−11.70%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0128-4139µs ± 0%113µs ± 0%−18.56%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0256-4136µs ± 0%116µs ± 0%−14.59%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:0512-4143µs ± 0%122µs ± 0%−14.83%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_10/ValueSize:1024-4145µs ± 0%132µs ± 0%−8.77%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0064-41.17ms ± 0%1.12ms ± 0%−4.73%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0128-41.27ms ± 0%1.16ms ± 0%−8.62%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0256-41.24ms ± 0%1.17ms ± 0%−5.49%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:0512-41.25ms ± 0%1.22ms ± 0%−2.60%(p=1.000 n=1+1)
_Storage_Simple_Write_Sync_100_100/ValueSize:1024-41.51ms ± 0%1.35ms ± 0%−10.65%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0064-48.73µs ± 0%8.57µs ± 0%−1.79%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0128-49.24µs ± 0%8.58µs ± 0%−7.17%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0256-410.3µs ± 0%9.3µs ± 0%−9.47%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:0512-412.1µs ± 0%11.1µs ± 0%−8.12%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_10_10/ValueSize:1024-415.2µs ± 0%15.0µs ± 0%−0.96%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0064-4103µs ± 0%86µs ± 0%−16.28%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0128-492.2µs ± 0%91.1µs ± 0%−1.16%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0256-4102µs ± 0%96µs ± 0%−6.35%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:0512-4139µs ± 0%115µs ± 0%−17.15%(p=1.000 n=1+1)
_Storage_Simple_Txn_Read_Sync_100_100/ValueSize:1024-4164µs ± 0%150µs ± 0%−8.65%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0064-4116µs ± 0%123µs ± 0%+5.75%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0128-4125µs ± 0%126µs ± 0%+0.83%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0256-4118µs ± 0%130µs ± 0%+9.82%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:0512-4118µs ± 0%126µs ± 0%+6.74%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_10_1_10/ValueSize:1024-4128µs ± 0%125µs ± 0%−2.24%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0064-41.22ms ± 0%1.20ms ± 0%−1.34%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0128-41.16ms ± 0%1.22ms ± 0%+4.86%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0256-41.19ms ± 0%1.23ms ± 0%+3.75%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:0512-41.19ms ± 0%1.18ms ± 0%−1.22%(p=1.000 n=1+1)
_Storage_Simple_Txn_Iterator_Sync_100_1_100/ValueSize:1024-41.24ms ± 0%1.28ms ± 0%+3.55%(p=1.000 n=1+1)
 

shahzadlone
shahzadlone approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@shahzadlone shahzadlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label Jul 26, 2022
@orpheuslummis
Copy link
Contributor Author

Added a commit that also silences cobra default printing of usage, also as per design of PR 649.

This PR makes me realize that there is a class of errors for which the CLI should print usage but is not currently printed, i.e. errors with flags... A subsequent PR should introduce parsing of the errors given by execution of root command to handle this .

@orpheuslummis orpheuslummis force-pushed the orpheus/fix/cli-errors branch from 3336d18 to 223a4ab Compare July 26, 2022 00:53
@codecov
Copy link

codecov bot commented Jul 26, 2022 •
edited
Loading

Codecov Report

Merging #668 (3336d18) into develop (c3d4517) will not change coverage.
The diff coverage is n/a.

❗ Current head 3336d18 differs from pull request most recent head 223a4ab. Consider uploading reports for the commit 223a4ab to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #668   +/-   ##
========================================
  Coverage    61.68%   61.68%           
========================================
  Files          123      123           
  Lines        14925    14925           
========================================
  Hits          9206     9206           
  Misses        4859     4859           
  Partials       860      860
Impacted Files Coverage Δ
logging/config.go 75.69% <0.00%> (ø)

@orpheuslummis orpheuslummis merged commit af5c3cc into develop Jul 26, 2022
@orpheuslummis orpheuslummis deleted the orpheus/fix/cli-errors branch July 26, 2022 00:59
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@orpheuslummis
fix: Silence cobra default errors and usage printing (sourcenetwork#668)
4b18b3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzadlone shahzadlone shahzadlone approved these changes

@fredcarle fredcarle fredcarle approved these changes

Assignees

@orpheuslummis orpheuslummis

Labels
action/no-benchmark Skips the action that runs the benchmark. area/cli Related to the CLI binary bug Something isn't working
Projects
None yet
Milestone
DefraDB v0.3
Development

Successfully merging this pull request may close these issues.

Silence cobra errors as per design of 649
4 participants
@orpheuslummis @source-devs @fredcarle @shahzadlone