Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Allow PR titles to end with a number #745

Merged
merged 1 commit into from
Aug 16, 2022
Merged

ci: Allow PR titles to end with a number #745

merged 1 commit into from
Aug 16, 2022

Conversation

shahzadlone
Copy link
Member

Relevant issue(s)

Resolves #744

Description

Allow PR Title to end with a number character.

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

PR title, CI, locally

Specify the platform(s) on which this was tested:

  • Arch Linux

@shahzadlone shahzadlone added the ci/build This is issue is about the build or CI system, and the administration of it. label Aug 16, 2022
@shahzadlone shahzadlone added this to the DefraDB v0.3.1 milestone Aug 16, 2022
@shahzadlone shahzadlone requested a review from a team August 16, 2022 03:57
@shahzadlone shahzadlone self-assigned this Aug 16, 2022
fredcarle
fredcarle approved these changes Aug 16, 2022
View reviewed changes
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahzadlone shahzadlone force-pushed the lone/ci/allow-pr-titles-to-end-with-a-number branch 2 times, most recently from 1482d11 to 4895d51 Compare August 16, 2022 04:00
@shahzadlone shahzadlone added the action/no-benchmark Skips the action that runs the benchmark. label Aug 16, 2022
@source-devs

This comment was marked as resolved.

Sign in to view
@shahzadlone shahzadlone changed the title ci: Allow PR titles to end with a number ci: Allow PR titles to end with a numbertest1 Aug 16, 2022
@shahzadlone shahzadlone changed the title ci: Allow PR titles to end with a numbertest1 ci: Allow PR titles to end with a number Aug 16, 2022
@sourcenetwork sourcenetwork deleted a comment from source-devs Aug 16, 2022
@sourcenetwork sourcenetwork deleted a comment from source-devs Aug 16, 2022
@shahzadlone shahzadlone merged commit 70dd79c into develop Aug 16, 2022
@shahzadlone shahzadlone deleted the lone/ci/allow-pr-titles-to-end-with-a-number branch August 16, 2022 04:14
shahzadlone added a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
@shahzadlone
ci: Allow PR titles to end with a number (sourcenetwork#745)
eb721bd 
- Resolves sourcenetwork#744 
- Allow PR Title to end with a number character.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredcarle fredcarle fredcarle approved these changes

Assignees

@shahzadlone shahzadlone

Labels
action/no-benchmark Skips the action that runs the benchmark. ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Milestone
DefraDB v0.3.1
Development

Successfully merging this pull request may close these issues.

Allow PR Title actions to allow ending with a number character
3 participants
@shahzadlone @source-devs @fredcarle