feat: Add cid support for allCommits #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
feature
Codecov Report
@@ Coverage Diff @@
## develop #857 +/- ##
===========================================
+ Coverage 59.72% 59.74% +0.02%
===========================================
Files 155 155
Lines 17332 17341 +9
===========================================
+ Hits 10351 10361 +10
+ Misses 6047 6046 -1
Partials 934 934
|
AndrewSisley
commented
Sep 22, 2022
| @@ -173,6 +173,18 @@ func (p *Planner) commitSelectBlock(parsed *mapper.CommitSelect) (*commitSelectN | |||
| func (p *Planner) commitSelectAll(parsed *mapper.CommitSelect) (*commitSelectNode, error) { | |||
| dag := p.DAGScan(parsed) | |||
| headset := p.HeadScan(parsed) | |||
|
|
|||
| if parsed.Cid != "" { | |||
There was a problem hiding this comment.
note: pasted from an above function, this can be improved in #858 once things are simpler
shahzadlone
approved these changes
Sep 23, 2022
| @@ -173,6 +173,18 @@ func (p *Planner) commitSelectBlock(parsed *mapper.CommitSelect) (*commitSelectN | |||
| func (p *Planner) commitSelectAll(parsed *mapper.CommitSelect) (*commitSelectNode, error) { | |||
| dag := p.DAGScan(parsed) | |||
| headset := p.HeadScan(parsed) | |||
|
|
|||
| if parsed.Cid != "" { | |||
AndrewSisley
force-pushed
the
sisley/feat/I840-commits-cid
branch
from
5907ee0 to
66b2566
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #840
Description
Adds cid support for allCommits. Let me know if you dont want this in 0.3.1
Specify the platform(s) on which this was tested: