-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update to v0.23.2 the libP2P package #908
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #908 +/- ##
===========================================
- Coverage 59.85% 59.79% -0.06%
===========================================
Files 156 156
Lines 17415 17415
===========================================
- Hits 10423 10414 -9
- Misses 6055 6065 +10
+ Partials 937 936 -1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming you fix the build first :)
err = nd.SetCidBuilder(cid.V1Builder{ | ||
Codec: cid.DagProtobuf, | ||
MhType: mh.SHA2_256, | ||
MhLength: -1, | ||
}) | ||
if err != nil { | ||
return nil, err | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated version of the go-merckledag
package has this method returning an error.
64e964b
to
5c2947d
Compare
Relevant issue(s) Resolves sourcenetwork#902 Description This PR updates libP2P to the latest version
Relevant issue(s)
Resolves #902
Description
This PR updates libP2P to the latest version
Tasks
How has this been tested?
make test
Specify the platform(s) on which this was tested: