Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update to v0.23.2 the libP2P package #908

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

fredcarle
Copy link
Collaborator

Relevant issue(s)

Resolves #902

Description

This PR updates libP2P to the latest version

Tasks

  • I made sure the code is well commented, particularly hard-to-understand areas.
  • I made sure the repository-held documentation is changed accordingly.
  • I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in tools/configs/chglog/config.yml).
  • I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ...

How has this been tested?

make test

Specify the platform(s) on which this was tested:

  • MacOS

@fredcarle fredcarle added area/p2p Related to the p2p networking system action/no-benchmark Skips the action that runs the benchmark. labels Oct 19, 2022
@fredcarle fredcarle added this to the DefraDB v0.4 milestone Oct 19, 2022
@fredcarle fredcarle requested a review from a team October 19, 2022 15:41
@fredcarle fredcarle self-assigned this Oct 19, 2022
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #908 (5c2947d) into develop (a82ae40) will decrease coverage by 0.05%.
The diff coverage is 62.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #908      +/-   ##
===========================================
- Coverage    59.85%   59.79%   -0.06%     
===========================================
  Files          156      156              
  Lines        17415    17415              
===========================================
- Hits         10423    10414       -9     
- Misses        6055     6065      +10     
+ Partials       937      936       -1     
Impacted Files Coverage Δ
core/net/protocol.go 77.77% <ø> (ø)
net/api/client/client.go 0.00% <ø> (ø)
net/api/service.go 8.69% <ø> (ø)
net/client.go 0.00% <ø> (ø)
net/dialer.go 3.12% <ø> (ø)
net/pb/custom.go 17.50% <ø> (ø)
net/peer.go 32.19% <ø> (ø)
net/server.go 55.93% <ø> (ø)
net/utils/util.go 47.82% <ø> (ø)
node/config.go 59.61% <ø> (ø)
... and 4 more

Copy link
Contributor

@AndrewSisley AndrewSisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you fix the build first :)

Comment on lines +128 to +135
err = nd.SetCidBuilder(cid.V1Builder{
Codec: cid.DagProtobuf,
MhType: mh.SHA2_256,
MhLength: -1,
})
if err != nil {
return nil, err
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated version of the go-merckledag package has this method returning an error.

@fredcarle fredcarle force-pushed the fredcarle/chore/I902-update-libp2p branch from 64e964b to 5c2947d Compare October 19, 2022 16:21
@fredcarle fredcarle merged commit 778bd36 into develop Oct 19, 2022
@fredcarle fredcarle deleted the fredcarle/chore/I902-update-libp2p branch October 19, 2022 16:47
shahzadlone pushed a commit to shahzadlone/defradb that referenced this pull request Feb 23, 2024
Relevant issue(s)
Resolves sourcenetwork#902

Description
This PR updates libP2P to the latest version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action/no-benchmark Skips the action that runs the benchmark. area/p2p Related to the p2p networking system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update libP2P to v0.23.2
2 participants