Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add or move the Lint Check action from CircleCi to Github Action #91

Closed
shahzadlone opened this issue Dec 13, 2021 · 1 comment · Fixed by #106
Closed

Add or move the Lint Check action from CircleCi to Github Action #91

shahzadlone opened this issue Dec 13, 2021 · 1 comment · Fixed by #106
Assignees
@shahzadlone
Labels
ci/build This is issue is about the build or CI system, and the administration of it.
Milestone
DefraDB v0.2

Comments

@shahzadlone
Copy link
Member

[Low Priority]

Perhaps look into the official GitHub action that is maintained by golangci-lint, mainly because the additional annotations for the linter issues are automatically annotated on Github like this:
image

Reference:
https://golangci-lint.run/usage/install/
@shahzadlone shahzadlone added the ci/build This is issue is about the build or CI system, and the administration of it. label Dec 13, 2021
@shahzadlone shahzadlone mentioned this issue Dec 13, 2021
Merged
@shahzadlone shahzadlone changed the title Add ot move the Lint Check action from CircleCi to Github Action Add or move the Lint Check action from CircleCi to Github Action Dec 13, 2021
@jsimnz
Copy link
Member

jsimnz commented Dec 13, 2021

I like the official method here over adding a CircleCI task. Made a comment in your PR #92. Basically, we can decide to work on the official method now and ignore circle CI, or just get it working and replace later with this.

@jsimnz jsimnz linked a pull request Jan 5, 2022 that will close this issue
ci: Integrate GitHub Action for golangci-lint Annotations #106
Merged
@shahzadlone shahzadlone added this to the DefraDB v0.2 milestone Jan 27, 2022
@shahzadlone shahzadlone self-assigned this Jan 27, 2022
@jsimnz jsimnz reopened this Jan 28, 2022
@jsimnz jsimnz closed this as completed Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
ci/build This is issue is about the build or CI system, and the administration of it.
Projects
None yet
Milestone
DefraDB v0.2
Development

Successfully merging a pull request may close this issue.

ci: Integrate GitHub Action for golangci-lint Annotations sourcenetwork/defradb
2 participants
@jsimnz @shahzadlone