Rule useless-else-on-loop does not account for break statements in nested for-loops

[ruancomelli]

Checklist

• I have searched the Sourcery documentation for the issue, and found nothing
• I have read the common issues and fixes listed in the Sourcery troubleshooting page, and found nothing
• I have checked there are no open bugs referencing the same bug or problem

Description

The rule useless-else-on-loop should NOT trigger in the following snippet, but it does:

for thing in things:
    for other_thing in other_things:
        pass  # inner body
    else:
        break
else:
    explode_computer()

rewriting it as

for thing in things:
    for other_thing in other_things:
        pass  # inner body
    else:
        break
explode_computer()

Debug Information

Sourcery Version: 1.8.0

Additional Information

A user reported this bug to our e-mail support.

[ruancomelli]

Additionally, the message "If else clause is always executed move code to same level as loop" is wrong.

[ruancomelli]

This was fixed by v1.10.0.