Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sourcery incorrectly skips re-reviewing PR #428

Closed
ruancomelli opened this issue Jun 13, 2024 · 1 comment
Closed

Sourcery incorrectly skips re-reviewing PR #428

ruancomelli opened this issue Jun 13, 2024 · 1 comment
Assignees
@ruancomelli
Labels
bug Something isn't working

Comments

@ruancomelli
Copy link
Contributor

Commenting @sourcery-ai review on a PR results in the bot commenting "We have skipped reviewing this pull request. It looks like we've already reviewed this pull request." even if new commits were introduced.

See yaitoo/sqle#47 (review) for an example.

Originally posted by @cnlangzi in #427 (comment)
@ruancomelli ruancomelli self-assigned this Jun 13, 2024
@ruancomelli ruancomelli added the bug Something isn't working label Jun 13, 2024
@ruancomelli ruancomelli mentioned this issue Jun 13, 2024
Closed
3 tasks
@ruancomelli
Copy link
Contributor Author

Hey @cnlangzi!

I've just merged and deployed a fix for this issue.
Sourcery will now perform re-reviews if you comment @sourcery-ai review after updating your PR, as expected.

Thanks for reporting this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruancomelli ruancomelli

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ruancomelli