Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail compilation on default setting. (fedora33) #288

Open
lighta opened this issue Nov 29, 2020 · 1 comment · May be fixed by #289
Open

Fail compilation on default setting. (fedora33) #288

lighta opened this issue Nov 29, 2020 · 1 comment · May be fixed by #289

Comments

@lighta
Copy link

lighta commented Nov 29, 2020

Hi, I;m getting this compilation error while trying to compile sha : 98df3c3
libsourcey/src/crypto/include/scy/crypto/hash.h:56:16: error: field ‘_ctx’ has incomplete type ‘EVP_MD_CTX’ {aka ‘evp_md_ctx_st’}

Env: Fedora33,
Compiler gcc10.
Here attached the compilation log
sourcey_compile_error.log

@lighta
Copy link
Author

lighta commented Nov 29, 2020

Issue is easily fixable.
On libsourcey/src/crypto/include/scy/crypto/hash.h
Why do you need to know the concrete type of EVP_MD_CTX ?, why don't do you want this on stack and not simply use the heap / opaque version ?

@lighta lighta linked a pull request Nov 29, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant