Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust lca summarize to use --with-abundance by default #1024

Closed
ctb opened this issue Jun 16, 2020 · 1 comment · Fixed by #1175
Closed

adjust lca summarize to use --with-abundance by default #1024

ctb opened this issue Jun 16, 2020 · 1 comment · Fixed by #1175
Labels
4.0 issues to address for a 4.0 release

Comments

@ctb
Copy link
Contributor

ctb commented Jun 16, 2020 •
edited
Loading

once #1022 is merged, the default behavior of sourmash lca summarize will still be to ignore abundances in the query signature. For a 4.0 release, this should be adjusted so that --with-abundance is the default.
@ctb ctb added the 4.0 issues to address for a 4.0 release label Jun 16, 2020
@ctb
Copy link
Contributor Author

ctb commented Jun 16, 2020

aaaaand probably we will need --ignore-abundance or something to be added instead.

This was referenced Aug 18, 2020
Merged
Closed
@ctb ctb closed this as completed in #1175 Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
4.0 issues to address for a 4.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] change default behavior in lca summarize sourmash-bio/sourmash
1 participant
@ctb