-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a 'name' config to sourmash sketch
param strings?
#1315
Comments
it would also be nice to support explicit naming from filename, and/or basename, and/or maybe even accession from a CSV of some sort. |
I REALLY like adding a template vars seem very handy, but maybe also dangerous? name from csv is what I end up doing via snakemake, so doing it natively would be neat :) |
also, see @taylorreiter comment in https://github.com/dib-lab/sourmash/pull/1283/files#r572495952 - docs say:
|
fixed in #1347 - name/filename is now empty.
added in 2ac0b96! |
we could allow
sourmash sketch
to takename=
in param strings, e.g.sourmash sketch dna -p k=31,name='cool name, luke'
rationale: when writing up the docs for sourmash sketch per #1283 (review), I realized that I had done signature naming the way I had because of limitations imposed by
sourmash compute
: to whit, that we could only specify one name on the command line for all the signatures being created.However, with
sourmash sketch
, we create different signatures for each param string.In a major scope expansion of this issue, we could also allow template variables like
{header}
and{len}
to be used, to be interpreted by Python for each sequence...The text was updated successfully, but these errors were encountered: